Replace reference screenshots #17597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
WIP
thomasneirynck
force-pushed
the
timroes-tagcloud-hashing
branch
from
4a06736
to
008bd9e
Compare
replace screenshot fix debug line fix test-code/replace screenshots
💚 Build Succeeded |
thomasneirynck
force-pushed
the
timroes-tagcloud-hashing
branch
from
008bd9e
to
44f9e7c
Compare
thomasneirynck
commented
Apr 6, 2018
|
|
||
| tagCloud = new TagCloud(domNode); | ||
| tagCloud.setData(baseTest.data); | ||
| tagCloud.setOptions(baseTest.options); | ||
|
|
||
| await fromNode(cb => tagCloud.once('renderComplete', cb)); | ||
|
|
||
| const mismatchedPixels = await imageComparator.compareDOMContents(domNode.innerHTML, 512, 512, simpleloadPng, 0.50); | ||
| const mismatchedPixels = await imageComparator.compareDOMContents(domNode.innerHTML, 512, 512, simpleloadPng, 0.35); |
There was a problem hiding this comment.
tighten down more.
| @@ -8,7 +8,7 @@ import basicdrawPng from './basicdraw.png'; | |||
| import afterresizePng from './afterresize.png'; | |||
| import afterparamChange from './afterparamchange.png'; | |||
|
|
|||
| const THRESHOLD = 0.65; | |||
| const THRESHOLD = 0.35; | |||
| await tagcloudVisualization.render(dummyTableGroup, { | ||
| resize: false, | ||
| params: true, | ||
| aggs: true, | ||
| data: true, | ||
| uiState: false | ||
| }); | ||
| const mismatchedPixels = await imageComparator.compareDOMContents(domNode.innerHTML, 512, 512, basicdrawPng, THRESHOLD); | ||
|
|
||
| const svgNode = domNode.querySelector('svg'); |
There was a problem hiding this comment.
this was a bug in the test-code. This PR (#15779) changed the internal DOM, and this unit test did not get updated accordingly. It didn't fail because comparison was too permissive, clouds have a lot of whitespace.
| sourceImage.onload = async () => { | ||
| sourceContext2d.drawImage(sourceImage, 0, 0); | ||
| const mismatch = await this.compareImage(sourceCanvas, expectedImageSourcePng, threshold); | ||
| document.body.removeChild(sourceCanvas); | ||
| resolve(mismatch); | ||
| }; | ||
| sourceImage.onerror = (e) => { | ||
| reject(e.message); | ||
| }; |
There was a problem hiding this comment.
make sure tests actually throw when image cannot be loaded.
💚 Build Succeeded |
|
cc @timroes |
|
jenkins, test this |
💚 Build Succeeded |
This was referenced Apr 9, 2018
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 9, 2018
pulls in TimR's changes (elastic#17594) to the hashing algorithm. This also replaces the reference screenshots to match the new rotations.
💚 Build Succeeded |
thomasneirynck
added a commit
that referenced
this pull request
Apr 10, 2018
Applies to Tagcloud. #17597 made them too strict, causing them to fail in CI.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 10, 2018
pulls in TimR's changes (elastic#17594) to the hashing algorithm. This also replaces the reference screenshots to match the new rotations.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 10, 2018
…ic#17626) Applies to Tagcloud. elastic#17597 made them too strict, causing them to fail in CI.
thomasneirynck
added a commit
that referenced
this pull request
Apr 11, 2018
* Change hashing algo of tagcloud rotations (#17597) pulls in TimR's changes (#17594) to the hashing algorithm. This also replaces the reference screenshots to match the new rotations. * Revert screenshot comparison tests to old threshold parameters (#17626) Applies to Tagcloud. #17597 made them too strict, causing them to fail in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulls in same changes as #17594