Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Update functional test assertion, reenable tests. #176920

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Feb 14, 2024

Summary

Fixes #151889
Fixes #151811
Fixes #176697
Fixes #176698
Fixes #176865

Updates assertions after ES snapshot promotion and reenables tests.

Checklist

@walterra walterra added the release_note:skip Skip the PR/issue when compiling release notes label Feb 14, 2024
@walterra walterra self-assigned this Feb 14, 2024
@walterra
Copy link
Contributor Author

walterra commented Feb 14, 2024

@walterra walterra marked this pull request as ready for review February 14, 2024 16:07
@walterra walterra requested a review from a team as a code owner February 14, 2024 16:07
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 21ca904 into elastic:main Feb 19, 2024
16 checks passed
@walterra walterra deleted the ml-transform-fix-test-assertions branch February 19, 2024 07:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2024
…lastic#176920)

## Summary

Fixes elastic#151889
Fixes elastic#151811
Fixes elastic#176697
Fixes elastic#176698
Fixes elastic#176865

Updates assertions after ES snapshot promotion and reenables tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 21ca904)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2024
…lastic#176920)

## Summary

Fixes elastic#151889
Fixes elastic#151811
Fixes elastic#176697
Fixes elastic#176698
Fixes elastic#176865

Updates assertions after ES snapshot promotion and reenables tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 21ca904)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2024
…lastic#176920)

## Summary

Fixes elastic#151889
Fixes elastic#151811
Fixes elastic#176697
Fixes elastic#176698
Fixes elastic#176865

Updates assertions after ES snapshot promotion and reenables tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 21ca904)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
7.17
8.12
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 19, 2024
…sts. (#176920) (#177150)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[ML] Transforms: Update functional test assertion, reenable tests.
(#176920)](#176920)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Walter
Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T07:59:53Z","message":"[ML]
Transforms: Update functional test assertion, reenable tests.
(#176920)\n\n## Summary\r\n\r\nFixes #151889\r\nFixes #151811\r\nFixes
#176697\r\nFixes #176698\r\nFixes #176865\r\n\r\nUpdates assertions
after ES snapshot promotion and reenables tests.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"21ca904cfd7eee75202b61c8e7be3e9ad6c2fda4","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Transforms","v8.13.0","v8.14.0","v7.17.19"],"title":"[ML]
Transforms: Update functional test assertion, reenable
tests.","number":176920,"url":"https://github.com/elastic/kibana/pull/176920","mergeCommit":{"message":"[ML]
Transforms: Update functional test assertion, reenable tests.
(#176920)\n\n## Summary\r\n\r\nFixes #151889\r\nFixes #151811\r\nFixes
#176697\r\nFixes #176698\r\nFixes #176865\r\n\r\nUpdates assertions
after ES snapshot promotion and reenables tests.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"21ca904cfd7eee75202b61c8e7be3e9ad6c2fda4"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","7.17"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176920","number":176920,"mergeCommit":{"message":"[ML]
Transforms: Update functional test assertion, reenable tests.
(#176920)\n\n## Summary\r\n\r\nFixes #151889\r\nFixes #151811\r\nFixes
#176697\r\nFixes #176698\r\nFixes #176865\r\n\r\nUpdates assertions
after ES snapshot promotion and reenables tests.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"21ca904cfd7eee75202b61c8e7be3e9ad6c2fda4"}},{"branch":"7.17","label":"v7.17.19","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Walter Rafelsberger <[email protected]>
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Feb 19, 2024
…lastic#176920)

## Summary

Fixes elastic#151889
Fixes elastic#151811
Fixes elastic#176697
Fixes elastic#176698
Fixes elastic#176865

Updates assertions after ES snapshot promotion and reenables tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine added a commit that referenced this pull request Feb 19, 2024
…sts. (#176920) (#177148)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[ML] Transforms: Update functional test assertion, reenable tests.
(#176920)](#176920)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Walter
Rafelsberger","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T07:59:53Z","message":"[ML]
Transforms: Update functional test assertion, reenable tests.
(#176920)\n\n## Summary\r\n\r\nFixes #151889\r\nFixes #151811\r\nFixes
#176697\r\nFixes #176698\r\nFixes #176865\r\n\r\nUpdates assertions
after ES snapshot promotion and reenables tests.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"21ca904cfd7eee75202b61c8e7be3e9ad6c2fda4","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Transforms","v8.13.0","v8.14.0","v7.17.19"],"title":"[ML]
Transforms: Update functional test assertion, reenable
tests.","number":176920,"url":"https://github.com/elastic/kibana/pull/176920","mergeCommit":{"message":"[ML]
Transforms: Update functional test assertion, reenable tests.
(#176920)\n\n## Summary\r\n\r\nFixes #151889\r\nFixes #151811\r\nFixes
#176697\r\nFixes #176698\r\nFixes #176865\r\n\r\nUpdates assertions
after ES snapshot promotion and reenables tests.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"21ca904cfd7eee75202b61c8e7be3e9ad6c2fda4"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","7.17"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176920","number":176920,"mergeCommit":{"message":"[ML]
Transforms: Update functional test assertion, reenable tests.
(#176920)\n\n## Summary\r\n\r\nFixes #151889\r\nFixes #151811\r\nFixes
#176697\r\nFixes #176698\r\nFixes #176865\r\n\r\nUpdates assertions
after ES snapshot promotion and reenables tests.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"21ca904cfd7eee75202b61c8e7be3e9ad6c2fda4"}},{"branch":"7.17","label":"v7.17.19","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Walter Rafelsberger <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…lastic#176920)

## Summary

Fixes elastic#151889
Fixes elastic#151811
Fixes elastic#176697
Fixes elastic#176698
Fixes elastic#176865

Updates assertions after ES snapshot promotion and reenables tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Transforms ML transforms release_note:skip Skip the PR/issue when compiling release notes v7.17.19 v8.12.2 v8.13.0 v8.14.0
Projects
None yet
4 participants