Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused legacy markdown component #179272

Merged

Conversation

eokoneyo
Copy link
Contributor

Summary

Removes previous markdown, since all its usage has been migrated to new markdown component.

@eokoneyo eokoneyo self-assigned this Mar 22, 2024
@eokoneyo
Copy link
Contributor Author

/ci

@eokoneyo eokoneyo force-pushed the chore/remove-deprecated-markdown-component branch from ab1f7fd to 6c68ead Compare March 25, 2024 10:47
@eokoneyo
Copy link
Contributor Author

/ci

@eokoneyo eokoneyo added release_note:fix Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Mar 26, 2024
@eokoneyo eokoneyo marked this pull request as ready for review March 26, 2024 15:44
@eokoneyo eokoneyo requested review from a team as code owners March 26, 2024 15:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo eokoneyo changed the title remove deprecated markdown component remove unused legacy markdown component Mar 26, 2024
@eokoneyo
Copy link
Contributor Author

@elasticmachine merge upstream

@eokoneyo
Copy link
Contributor Author

eokoneyo commented Apr 2, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaReact 268 116 -152

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaReact 121 117 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 165.6KB 0.0B -165.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibanaReact 3 1 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 40.3KB 38.6KB -1.7KB
Unknown metric groups

API count

id before after diff
kibanaReact 153 149 -4

async chunk count

id before after diff
kibanaReact 2 0 -2

ESLint disabled line counts

id before after diff
kibanaReact 3 0 -3

Total ESLint disabled count

id before after diff
kibanaReact 3 0 -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

@eokoneyo eokoneyo merged commit 2e6d8d2 into elastic:main Apr 3, 2024
16 checks passed
@eokoneyo eokoneyo deleted the chore/remove-deprecated-markdown-component branch April 3, 2024 10:12
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Apr 3, 2024
eokoneyo added a commit to eokoneyo/kibana that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants