Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolutions] Update asset criticality upload page visibility and permissions #180771

Merged
merged 7 commits into from
Apr 16, 2024
Merged

[SecuritySolutions] Update asset criticality upload page visibility and permissions #180771

merged 7 commits into from
Apr 16, 2024

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Apr 15, 2024 •
edited
Loading

Summary

Related to #179891

  • Display error message in case user doesn't have write access to asset criticality index
    Screenshot 2024-04-15 at 14 34 17

  • Display error message if the user navigates to the page when the user advanced (UI) setting is disabled
    Screenshot 2024-04-15 at 14 32 35

  • Remove links from menus and global search if advanced (UI) setting is disabled
    Screenshot 2024-04-15 at 14 40 35

Recoding of what happens when you don't refresh the page:

Screen.Recording.2024-04-15.at.14.35.16.small.mov

Expected behaviour:

  • After the setting is enabled, the user needs to refresh the browser to find the page
  • If users disable the setting on a different browser/tab and navigate to the page without refreshing, they will see an error message on the page.
  • If users disable the flag while the page is already rendered and try to upload the file, it will display an error on the last step.

Checklist

Delete any items that are not applicable to this PR.

@machadoum
Copy link
Member Author

/ci

@machadoum machadoum force-pushed the siem-ea-9047-setting branch 3 times, most recently from 51747ad to d95d2f7 Compare April 15, 2024 09:30
@machadoum
Copy link
Member Author

/ci

1 similar comment
@machadoum
Copy link
Member Author

/ci

@machadoum
Copy link
Member Author

/ci

@machadoum machadoum self-assigned this Apr 15, 2024
@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Entity Analytics Security Entity Analytics Team labels Apr 15, 2024
@machadoum machadoum marked this pull request as ready for review April 15, 2024 12:42
@machadoum machadoum requested review from a team as code owners April 15, 2024 12:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

machadoum
machadoum commented Apr 15, 2024
View reviewed changes
x-pack/plugins/security_solution/tsconfig.json
@@ -196,6 +196,7 @@
"@kbn/core-http-server-mocks",
"@kbn/data-service",
"@kbn/core-chrome-browser",
"@kbn/shared-ux-chrome-navigation"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-generated 8e1f50e

tiansivive
tiansivive approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a small comment

x-pack/plugins/security_solution/public/common/links/links.ts Outdated Show resolved Hide resolved
@machadoum machadoum enabled auto-merge (squash) April 15, 2024 13:19
@machadoum machadoum disabled auto-merge April 15, 2024 13:40
@machadoum machadoum requested a review from a team as a code owner April 15, 2024 14:37
semd
semd approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks Pablo for doing this 💯

@machadoum machadoum enabled auto-merge (squash) April 15, 2024 15:11
@machadoum machadoum merged commit da890be into elastic:main Apr 16, 2024
35 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 17.5MB 17.5MB +1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 80.2KB 80.5KB +334.0B
Unknown metric groups

API count

id before after diff
securitySolution 188 189 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@tiansivive tiansivive tiansivive approved these changes

@semd semd semd approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

@machadoum machadoum

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@machadoum @elasticmachine @kibana-ci @pzl @tiansivive @semd @kibanamachine