[8.14] [ES|QL] Rename the setting to a more generic one and move to the general section (#182074) #182252
+117
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ral section (elastic#182074) ## Summary Renames the setting from discover:enableESQL to enableESQL and moves it to the General Section <img width="985" alt="image" src="https://github.com/elastic/kibana/assets/17003240/ebafe7cd-4695-413c-a0e3-90e3574139e5"> We checked the telemetry and a very small percentage of users have switched off this setting. It was also on tech preview so we decided in favor of this change as more and more applications are using this setting to hide ESQL from their applications. <img width="850" alt="image" src="https://github.com/elastic/kibana/assets/17003240/404f2494-8a17-4a9d-943a-d9d72b324bc0"> ### Release note We renamed the advanced setting which hides the ES|QL from the UI from `discover:enableESQL` to `enableESQL`. You have to switch it off again if you want to disable ES|QL features from your kibana applications. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f3d18fa) # Conflicts: # config/serverless.yml # packages/kbn-management/settings/setting_ids/index.ts # x-pack/plugins/data_visualizer/tsconfig.json # x-pack/plugins/lens/public/trigger_actions/open_lens_config/in_app_embeddable_edit/in_app_embeddable_edit_action_helpers.tsx # x-pack/plugins/ml/tsconfig.json
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
To update your PR or re-run it, just comment with: |
timductive
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.14:Questions ?
Please refer to the Backport tool documentation