[Security Solution] Rename rulesManagementClient -> detectionRulesClient
#184598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaindik
added
refactoring
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
17 tasks
banderror
requested review from
e40pud and
yctercero
and removed request for
rylnd
banderror
approved these changes
May 31, 2024
There was a problem hiding this comment.
This is a good name improvement! Thanks for carefully renaming it everywhere @nikitaindik, LGTM 👍
e40pud
approved these changes
Jun 3, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nikitaindik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #184364
Summary
As a first step in refactoring our newly added
rulesManagementClient, we are renaming it fromrulesManagementClienttodetectionRulesClient.rulesManagementClientlooks and sounds too similar to a long existingrulesClient, so it can be confusing to new devs or anyone quickly digging through the code.This PR just updates the name. Other refactorings will be arriving in the upcoming PRs.