Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.2.0 #186841

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Upgrade EUI to v95.2.0 #186841

merged 8 commits into from
Jun 28, 2024

Conversation

cee-chen
Copy link
Member

v95.1.0v95.2.0

Questions? Please see our Kibana upgrade FAQ.


v95.2.0

  • Updated EuiContextMenuItemIcon's type definition to explicitly define support for EuiIcon's IconType (#7804)
  • Updated EuiSteps to support a new titleSize="xxs" style, which outputs the same title font size but smaller unnumbered step indicators (#7813)
  • Updated EuiStepsHorizontal to support a new size="xs" style, which outputs smaller unnumbered step indicators (#7813)
  • Updated EuiStepNumber to support new titleSize="none" which omits rendering step numbers, and will only render icons (#7813)
  • Updated setEuiDevProviderWarning to additionally accept a custom callback function, which warning messages will be passed to (#7820)
  • Updated EuiIcon to feature updated logoElasticStack logo for referencing Elastic Stack platform (#7838)
  • Updated EuiIcon to feature updated casesApp design. (#7840)
  • Updated EuiComboBox to no longer autocomplete searched text when used within forms (#7842)

CSS-in-JS conversions

  • Converted EuiFilePicker to Emotion; Removed $euiFilePickerTallHeight (#7833)

@cee-chen cee-chen added EUI v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 24, 2024
@cee-chen cee-chen force-pushed the eui/v95.2.0 branch 3 times, most recently from 3e65d29 to 6f49a9b Compare June 24, 2024 18:13
@cee-chen cee-chen force-pushed the eui/v95.2.0 branch 3 times, most recently from f9be5e8 to c29a5c6 Compare June 25, 2024 19:46
- requires some amount of type casting, as our theme HOCs sadly do not return class components from the ref
no parameter/fake event needs to be passed, it's optional
- shallow: target the Class now not the HOC'd component

- mount: needs to specify `.last()` now because Emotion adds another wrapper to Enzyme, and we want the nested one
@cee-chen
Copy link
Member Author

/ci

@cee-chen cee-chen marked this pull request as ready for review June 25, 2024 23:10
@cee-chen cee-chen requested review from a team as code owners June 25, 2024 23:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen requested a review from rylnd June 25, 2024 23:10
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jun 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML edit LGTM (gave Import calendar event a visual check).

@ashokaditya ashokaditya requested review from tomsonpl and removed request for ashokaditya June 26, 2024 12:36
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management changes lgtm (kbn-management/settings/components/field_input/input/image_input.tsx)

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis snapshot change lgtm!

Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested osquery changes locally, no regression spotted.
👍

@cee-chen cee-chen enabled auto-merge (squash) June 27, 2024 20:15
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 28, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Osquery Cypress Tests #3 / Alert Event Details - Cases Case creation runs osquery against alert and creates a new case runs osquery against alert and creates a new case
  • [job] [logs] Serverless Osquery Cypress Tests #3 / Alert Event Details - Cases Case creation runs osquery against alert and creates a new case runs osquery against alert and creates a new case
  • [job] [logs] Osquery Cypress Tests #3 / Alert Event Details - Cases Case sees osquery results from last action and add to a case sees osquery results from last action and add to a case
  • [job] [logs] Serverless Osquery Cypress Tests #3 / Alert Event Details - Cases Case sees osquery results from last action and add to a case sees osquery results from last action and add to a case
  • [job] [logs] Osquery Cypress Tests #5 / Alert Event Details - dynamic params should substitute parameters in investigation guide should substitute parameters in investigation guide
  • [job] [logs] Serverless Osquery Cypress Tests #5 / Alert Event Details - dynamic params should substitute parameters in investigation guide should substitute parameters in investigation guide
  • [job] [logs] Osquery Cypress Tests #4 / Alert Event Details should be able to run live query and add to timeline should be able to run live query and add to timeline
  • [job] [logs] Serverless Osquery Cypress Tests #4 / Alert Event Details should be able to run live query and add to timeline should be able to run live query and add to timeline
  • [job] [logs] Osquery Cypress Tests #2 / Alert Test t1_analyst role "before each" hook for "should be able to run rule investigation guide query" "before each" hook for "should be able to run rule investigation guide query"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 558.8KB 558.9KB +108.0B
alerting 91.4KB 91.5KB +36.0B
apm 3.5MB 3.5MB +72.0B
canvas 1.1MB 1.1MB +36.0B
cloudDataMigration 5.8KB 5.9KB +36.0B
cloudSecurityPosture 450.4KB 450.5KB +36.0B
console 457.0KB 457.0KB +36.0B
controls 202.2KB 202.3KB +108.0B
crossClusterReplication 148.8KB 148.8KB +36.0B
dashboard 503.6KB 503.6KB +72.0B
dataQuality 25.3KB 25.4KB +36.0B
dataViewManagement 137.0KB 137.1KB +36.0B
dataVisualizer 759.7KB 759.8KB +108.0B
devTools 7.7KB 7.7KB +36.0B
discover 809.1KB 809.1KB +36.0B
enterpriseSearch 2.7MB 2.7MB +36.0B
eventAnnotationListing 300.8KB 300.8KB +36.0B
exploratoryView 268.7KB 268.7KB +36.0B
filesManagement 109.7KB 109.8KB +36.0B
graph 402.2KB 402.3KB +36.0B
grokdebugger 11.0KB 11.0KB +36.0B
home 151.8KB 151.9KB +36.0B
imageEmbeddable 66.9KB 67.0KB +72.0B
indexLifecycleManagement 150.3KB 150.3KB +36.0B
infra 1.5MB 1.5MB +108.0B
inputControlVis 52.0KB 52.1KB +36.0B
kibanaOverview 53.6KB 53.6KB +36.0B
kubernetesSecurity 212.0KB 212.0KB +36.0B
licenseManagement 46.5KB 46.5KB +36.0B
links 23.0KB 23.0KB +36.0B
logstash 33.3KB 33.4KB +36.0B
management 45.6KB 45.6KB +36.0B
metricsDataAccess 101.1KB 101.1KB +36.0B
ml 4.6MB 4.6MB +324.0B
monitoring 533.3KB 533.4KB +36.0B
observability 365.7KB 365.7KB +36.0B
observabilityLogsExplorer 143.2KB 143.3KB +36.0B
observabilityOnboarding 209.1KB 209.1KB +36.0B
osquery 1.0MB 1.0MB -85.0B
painlessLab 18.5KB 18.5KB +36.0B
profiling 405.7KB 405.8KB +36.0B
remoteClusters 78.9KB 78.9KB +36.0B
rollup 115.5KB 115.5KB +36.0B
savedObjectsManagement 84.4KB 84.5KB +36.0B
searchHomepage 35.2KB 35.2KB +36.0B
searchInferenceEndpoints 45.7KB 45.7KB +36.0B
searchNotebooks 11.8KB 11.9KB +36.0B
searchPlayground 168.1KB 168.1KB +36.0B
searchprofiler 161.1KB 161.1KB +36.0B
securitySolution 15.4MB 15.4MB +180.0B
serverlessSearch 513.3KB 513.4KB +72.0B
slo 870.7KB 870.9KB +180.0B
snapshotRestore 262.1KB 262.1KB +36.0B
synthetics 1.0MB 1.0MB +36.0B
timelines 32.8KB 32.8KB +36.0B
transform 632.5KB 632.5KB +36.0B
triggersActionsUi 1.7MB 1.7MB +252.0B
uptime 467.2KB 467.2KB +36.0B
ux 167.6KB 167.6KB +36.0B
watcher 166.0KB 166.0KB +36.0B
total +3.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 7.4KB 7.4KB +36.0B
banners 10.4KB 10.4KB +36.0B
cases 151.6KB 151.7KB +36.0B
cloudChat 14.1KB 14.1KB +36.0B
cloudLinks 30.1KB 30.1KB +36.0B
core 417.3KB 417.4KB +36.0B
dashboardEnhanced 17.7KB 17.7KB +36.0B
data 420.2KB 420.2KB +36.0B
dataViewEditor 13.5KB 13.5KB +36.0B
dataViewFieldEditor 26.5KB 26.6KB +36.0B
embeddable 71.2KB 71.3KB +36.0B
esUiShared 158.1KB 158.1KB +36.0B
expressionError 7.6KB 7.7KB +36.0B
expressionGauge 16.2KB 16.3KB +36.0B
expressionHeatmap 17.1KB 17.2KB +36.0B
expressionImage 6.8KB 6.8KB +36.0B
expressionLegacyMetricVis 12.5KB 12.5KB +36.0B
expressionMetric 8.2KB 8.3KB +36.0B
expressionMetricVis 16.1KB 16.2KB +36.0B
expressionPartitionVis 28.9KB 29.0KB +36.0B
expressionRepeatImage 8.5KB 8.6KB +36.0B
expressionRevealImage 8.5KB 8.5KB +36.0B
expressionShape 23.2KB 23.2KB +36.0B
expressionTagcloud 13.0KB 13.1KB +36.0B
expressionXY 41.7KB 41.7KB +36.0B
fleet 166.9KB 166.9KB +36.0B
globalSearchBar 28.6KB 28.6KB +36.0B
guidedOnboarding 29.5KB 29.6KB +36.0B
indexManagement 43.5KB 43.5KB +36.0B
ingestPipelines 16.7KB 16.7KB +36.0B
inspector 24.9KB 24.9KB +36.0B
interactiveSetup 59.6KB 59.6KB +36.0B
kbnUiSharedDeps-css 217.9KB 212.7KB -5.2KB
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +4.5KB
kibanaReact 39.3KB 39.4KB +36.0B
kibanaUtils 71.8KB 71.8KB +36.0B
lens 49.4KB 49.4KB +36.0B
licensing 11.6KB 11.6KB +36.0B
maps 54.5KB 54.5KB +36.0B
mockIdpPlugin 10.6KB 10.6KB +36.0B
navigation 16.0KB 16.0KB +36.0B
newsfeed 12.5KB 12.5KB +36.0B
observabilityAIAssistantApp 12.6KB 12.6KB +36.0B
osquery 46.8KB 46.9KB +36.0B
presentationPanel 43.5KB 43.5KB +36.0B
reporting 52.9KB 52.9KB +36.0B
runtimeFields 13.8KB 13.9KB +36.0B
savedObjects 25.5KB 25.5KB +36.0B
savedObjectsTagging 22.7KB 22.7KB +36.0B
security 69.5KB 69.5KB +36.0B
serverless 13.8KB 13.8KB +36.0B
share 56.2KB 56.3KB +36.0B
spaces 27.5KB 27.5KB +36.0B
telemetry 22.2KB 22.2KB +36.0B
uiActions 23.4KB 23.4KB +36.0B
unifiedSearch 38.8KB 38.8KB +36.0B
upgradeAssistant 24.7KB 24.7KB +36.0B
visDefaultEditor 23.9KB 24.0KB +36.0B
visTypeMarkdown 9.6KB 9.7KB +36.0B
visTypeTable 19.2KB 19.2KB +36.0B
visTypeTimelion 13.4KB 13.4KB +36.0B
visTypeTimeseries 20.6KB 20.6KB +36.0B
visTypeVega 36.1KB 36.2KB +36.0B
visTypeVislib 15.3KB 15.3KB +36.0B
visualizations 63.2KB 63.2KB +36.0B
total +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Member

jbudz commented Jun 28, 2024

^ Tests are failing on main. Merging this now.

@jbudz jbudz disabled auto-merge June 28, 2024 22:37
@jbudz jbudz merged commit 2bcc2fd into elastic:main Jun 28, 2024
41 of 51 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 28, 2024
@cee-chen cee-chen deleted the eui/v95.2.0 branch July 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.