Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix prebuiltRulesCustomizationEnabled feature flag #186964

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[Security Solution] Fix prebuiltRulesCustomizationEnabled feature flag #186964

merged 1 commit into from
Jun 26, 2024

Conversation

banderror
Copy link
Contributor

Resolves: #180130
Follow-up to: #186823

Summary

  • Adds more information to the feature flag's JSDoc comment according to the template we use for feature flags.
  • Changes the ticket's link to a public one.

@banderror banderror added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.15.0 labels Jun 26, 2024
@banderror banderror self-assigned this Jun 26, 2024
@banderror banderror requested a review from a team as a code owner June 26, 2024 10:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

nikitaindik
nikitaindik approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@nikitaindik nikitaindik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I'll keep in mind that all links in experimental_features.ts should preferably be public.

@banderror banderror enabled auto-merge (squash) June 26, 2024 10:24
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@banderror banderror merged commit 34f76ad into elastic:main Jun 26, 2024
48 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 26, 2024
@banderror banderror deleted the fix-prebuilt-rule-customization-feature-flag branch June 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitaindik nikitaindik nikitaindik approved these changes

Assignees

@banderror banderror

Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Add a new feature flag prebuiltRulesCustomizationEnabled
5 participants
@banderror @elasticmachine @kibana-ci @nikitaindik @kibanamachine