[A11y][TableListView] Refactor to use context to return focus #188774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
/ci |
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
Historycc @rshen91 |
|
/ci |
sebelga
reviewed
Jul 22, 2024
| @@ -43,7 +43,8 @@ const saveBtnWrapperCSS = css` | |||
| width: 100%; | |||
| `; | |||
|
|
|||
| interface Props { | |||
| interface Context { | |||
| enabled: boolean; | |||
There was a problem hiding this comment.
I don't think we need to pass the enabled and handle it on L61 as the consumer (the panel) does not render if tagging is not enabled.
There was a problem hiding this comment.
Good call - commit ed518a2 for changes
rshen91
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @rshen91 |
kibanamachine
added
v8.16.0
backport:skip
Dosant
reviewed
Jul 23, 2024
| /> | ||
| <TagFilterContextProvider | ||
| isPopoverOpen={isPopoverOpen} | ||
| isInUse={isInUse} |
There was a problem hiding this comment.
@sebelga, if I am not mistaken, we can simplify further because isInUse was a workaround for the problem that should be solved with context
There was a problem hiding this comment.
Needs to be checked but it could probably be removed indeed 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/observability-dev/issues/3345
Refactoring the tags portion of the table list view to return focus after closing the tags popover