[APM] Fix labels.served_from_cache type
#188836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
@elasticmachine merge upstream |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6609[✅] test/api_integration/config.js: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6610[✅] x-pack/test/apm_api_integration/trial/config.ts: 25/25 tests passed. |
crespocarlos
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
@elasticmachine merge upstream |
botelastic
bot
added
the
ci:project-deploy-observability
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 24, 2024
fixes [elastic#176425](elastic#176425) fixes [elastic#176544](elastic#176544) ## Summary The problem happens intermittently, I've managed to reproduce it a few times though. I suspect that since the es_archive `8.0.0` does not have a type definition for the `label.served_from_cache` field, it leaves ES to determine what's the appropriate type, therefore causing ingestion to sometimes fail. The `apm_8.0.0` has a type definition for this field for `transaction` index https://github.com/elastic/kibana/blob/main/x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0/mappings.json#L18824, so I followed the same configuration. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 850aa69)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 24, 2024
…189061) # Backport This will backport the following commits from `main` to `8.15`: - [[APM] Fix `labels.served_from_cache` type (#188836)](#188836) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-24T12:08:52Z","message":"[APM] Fix `labels.served_from_cache` type (#188836)\n\nfixes [#176425](https://github.com/elastic/kibana/issues/176425)\r\nfixes [#176544](https://github.com/elastic/kibana/issues/176544)\r\n\r\n## Summary\r\n\r\nThe problem happens intermittently, I've managed to reproduce it a few\r\ntimes though. I suspect that since the es_archive `8.0.0` does not have\r\na type definition for the `label.served_from_cache` field, it leaves ES\r\nto determine what's the appropriate type, therefore causing ingestion to\r\nsometimes fail.\r\n\r\nThe `apm_8.0.0` has a type definition for this field for `transaction`\r\nindex\r\nhttps://github.com/elastic/kibana/blob/main/x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0/mappings.json#L18824,\r\nso I followed the same configuration.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"850aa6964898adbe4659a748b9b4ebc59e54366b","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[APM] Fix `labels.served_from_cache` type","number":188836,"url":"https://github.com/elastic/kibana/pull/188836","mergeCommit":{"message":"[APM] Fix `labels.served_from_cache` type (#188836)\n\nfixes [#176425](https://github.com/elastic/kibana/issues/176425)\r\nfixes [#176544](https://github.com/elastic/kibana/issues/176544)\r\n\r\n## Summary\r\n\r\nThe problem happens intermittently, I've managed to reproduce it a few\r\ntimes though. I suspect that since the es_archive `8.0.0` does not have\r\na type definition for the `label.served_from_cache` field, it leaves ES\r\nto determine what's the appropriate type, therefore causing ingestion to\r\nsometimes fail.\r\n\r\nThe `apm_8.0.0` has a type definition for this field for `transaction`\r\nindex\r\nhttps://github.com/elastic/kibana/blob/main/x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0/mappings.json#L18824,\r\nso I followed the same configuration.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"850aa6964898adbe4659a748b9b4ebc59e54366b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188836","number":188836,"mergeCommit":{"message":"[APM] Fix `labels.served_from_cache` type (#188836)\n\nfixes [#176425](https://github.com/elastic/kibana/issues/176425)\r\nfixes [#176544](https://github.com/elastic/kibana/issues/176544)\r\n\r\n## Summary\r\n\r\nThe problem happens intermittently, I've managed to reproduce it a few\r\ntimes though. I suspect that since the es_archive `8.0.0` does not have\r\na type definition for the `label.served_from_cache` field, it leaves ES\r\nto determine what's the appropriate type, therefore causing ingestion to\r\nsometimes fail.\r\n\r\nThe `apm_8.0.0` has a type definition for this field for `transaction`\r\nindex\r\nhttps://github.com/elastic/kibana/blob/main/x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0/mappings.json#L18824,\r\nso I followed the same configuration.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"850aa6964898adbe4659a748b9b4ebc59e54366b"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #176425
fixes #176544
Summary
The problem happens intermittently, I've managed to reproduce it a few times though. I suspect that since the es_archive
8.0.0does not have a type definition for thelabel.served_from_cachefield, it leaves ES to determine what's the appropriate type, therefore causing ingestion to sometimes fail.The
apm_8.0.0has a type definition for this field fortransactionindex https://github.com/elastic/kibana/blob/main/x-pack/test/apm_api_integration/common/fixtures/es_archiver/apm_8.0.0/mappings.json#L18824, so I followed the same configuration.