Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5s minRefreshInterval to timefilter with validation #188881

Merged
merged 29 commits into from
Aug 23, 2024
Merged

Add 5s minRefreshInterval to timefilter with validation #188881

merged 29 commits into from
Aug 23, 2024

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jul 22, 2024 •
edited
Loading

Summary

Set global min refresh interval in timeFilter with validation.

Zight Recording 2024-07-22 at 03 12 22 PM

closes #176256

Checklist

@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 22, 2024
nickofthyme
nickofthyme commented Jul 22, 2024
View reviewed changes
Copy link
Contributor Author

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasneirynck, @ThomThomson & @lukasolson Could you take a look at this first pass and let me know if I'm on the right track? Thanks 🙏🏼

src/plugins/data/public/query/timefilter/timefilter.ts Show resolved Hide resolved
src/plugins/data/public/query/timefilter/timefilter.ts Outdated Show resolved Hide resolved
src/plugins/data/public/query/timefilter/timefilter_service.ts Outdated Show resolved Hide resolved
@nickofthyme nickofthyme changed the title Add 5s min refresh interval to timefilter with validation Add 5s minRefreshInterval to timefilter with validation Jul 22, 2024
@nickofthyme nickofthyme mentioned this pull request Jul 23, 2024
Merged
1 task
@elastic elastic deleted a comment from kibana-ci Aug 7, 2024
kibanamachine and others added 15 commits August 7, 2024 00:44
@nickofthyme nickofthyme marked this pull request as ready for review August 12, 2024 18:49
@nickofthyme nickofthyme requested review from a team as code owners August 12, 2024 18:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kc13greiner kc13greiner self-requested a review August 12, 2024 19:37
kc13greiner
kc13greiner approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeOwner review - LGTM!

@lukasolson

This comment was marked as resolved.

Sign in to view
nickofthyme
nickofthyme commented Aug 13, 2024
View reviewed changes
src/plugins/data/config.ts Outdated Show resolved Hide resolved
src/plugins/data/config.ts Outdated Show resolved Hide resolved
@nickofthyme
Copy link
Contributor Author

Codeonwer review please @elastic/appex-sharedux, @elastic/kibana-visualizations, @elastic/security-solution, @elastic/kibana-data-discovery, @elastic/ml-ui

lukasolson
lukasolson approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Just had some very minor feedback. Will we want to add this new config value to the allowed list inside cloud?

src/plugins/data/public/plugin.ts Show resolved Hide resolved
src/plugins/data/public/query/query_service.ts Show resolved Hide resolved
src/plugins/data/public/query/query_service.ts Show resolved Hide resolved
mbondyra
mbondyra approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

darnautov
darnautov approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsullivan
tsullivan approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme
Copy link
Contributor Author

@elastic/security-solution

logeekal
logeekal approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk tested on Serverless. Works great 🚀.

@nickofthyme nickofthyme enabled auto-merge (squash) August 23, 2024 15:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 843.6KB 843.6KB +17.0B
unifiedSearch 218.9KB 219.0KB +89.0B
total +106.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 418.1KB 418.7KB +577.0B
securitySolution 86.2KB 86.3KB +109.0B
unifiedSearch 38.8KB 38.9KB +98.0B
total +784.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit 94b657e into elastic:main Aug 23, 2024
41 checks passed
@nickofthyme nickofthyme deleted the min-refresh-interval branch August 23, 2024 16:21
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kc13greiner kc13greiner kc13greiner approved these changes

@logeekal logeekal logeekal approved these changes

@darnautov darnautov darnautov approved these changes

@mbondyra mbondyra mbondyra approved these changes

@lukasolson lukasolson lukasolson approved these changes

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Serverless] [Unified Search] Increase minimum refresh interval to 5s.
10 participants
@nickofthyme @elasticmachine @lukasolson @kibana-ci @tsullivan @mbondyra @darnautov @logeekal @kc13greiner @kibanamachine