Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(investigate): move behind feature flag #189290

Merged
merged 5 commits into from
Jul 26, 2024
Merged

chore(investigate): move behind feature flag #189290

merged 5 commits into from
Jul 26, 2024

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Jul 26, 2024 •
edited by mgiota
Loading

Fixes #187666

Mark the Investigate app as inaccessible when feature flag xpack.investigateApp.enabled is not set to true.

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 labels Jul 26, 2024
@kdelemme kdelemme marked this pull request as ready for review July 26, 2024 13:34
@kdelemme kdelemme requested a review from a team as a code owner July 26, 2024 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 26, 2024
@paulb-elastic paulb-elastic mentioned this pull request Jul 26, 2024
Closed
@kdelemme kdelemme enabled auto-merge (squash) July 26, 2024 15:30
@kdelemme kdelemme requested a review from a team as a code owner July 26, 2024 17:52
@kdelemme kdelemme requested a review from a team as a code owner July 26, 2024 18:33
TinaHeiligers
TinaHeiligers reviewed Jul 26, 2024
View reviewed changes
src/plugins/kibana_usage_collection/server/collectors/application_usage/schema.ts
@@ -152,7 +152,6 @@ export const applicationUsageSchema = {
fleet: commonSchema,
integrations: commonSchema,
ingestManager: commonSchema,
investigate: commonSchema,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need investigate when the feature flag is true. Are the telemetry functional tests green locally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 26, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
investigateApp 12.9KB 13.0KB +136.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme merged commit 8fb9d64 into elastic:main Jul 26, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 26, 2024
@kdelemme kdelemme deleted the rca/hide-app branch July 27, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RCA] Put Investigation UI related stuff behind a feature flag
7 participants
@kdelemme @obltmachine @elasticmachine @kibana-ci @TinaHeiligers @maryam-saeidi @kibanamachine