Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v95.5.0 #189436

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Upgrade EUI to v95.5.0 #189436

merged 12 commits into from
Aug 1, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Jul 29, 2024 •
edited
Loading

v95.4.0 ⏩ v95.5.0

Questions? Please see our Kibana upgrade FAQ.

v95.5.0

  • Added minusInSquare and plusInSquare glyphs to EuiIcon. (#7875)

Bug fixes

  • Fixed EuiSuperDatePicker not correctly passing refreshMinInterval from the quick select popover (#7905)

CSS-in-JS conversions

  • Converted EuiSuperDatePicker's form control to Emotion; (#7904)
    • Removed $euiSuperDatePickerWidth
    • Removed $euiSuperDatePickerButtonWidth
    • Removed $euiSuperDatePickerNeedsUpdatingBackgroundColor
    • Removed $euiSuperDatePickerNeedsUpdatingTextColor
    • Removed @euiSuperDatePickerText mixin
  • Converted EuiSuperDatePicker's date popover content to Emotion (#7908)
  • Converted EuiSuperDatePicker's quick select to Emotion (#7909)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.16.0 labels Jul 29, 2024
@cee-chen
Copy link
Member Author

/ci

@cee-chen
[EuiSuperDatePicker] Update test selectors
acdb33b 
- a lot of Enzyme tweaks to account for new Emotion wrapper
- a className*= change for a removed className, + test assertion updates
@cee-chen
[EuiSuperDatePicker] Update FTR className reference to data-test-subj
c50ec62
@cee-chen
[FTR] Tweak visual snapshot diff ratio
ce200f6
@cee-chen
Copy link
Member Author

/ci

@cee-chen cee-chen marked this pull request as ready for review July 29, 2024 22:21
@cee-chen cee-chen requested review from a team as code owners July 29, 2024 22:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

TinaHeiligers
TinaHeiligers approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in core-owned code LGTM

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 29, 2024
wayneseymour

This comment was marked as resolved.

Sign in to view

peteharverson
peteharverson approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit to transform functional test LGTM

cauemarcondes
cauemarcondes approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cee-chen

This comment was marked as resolved.

Sign in to view
ThomThomson
ThomThomson approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threshold increase LGTM! 0.021 is still very low so it's probably not yet time to update the baseline.

wayneseymour
wayneseymour approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cee-chen
Copy link
Member Author

cee-chen commented Aug 1, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 1, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.0MB 3.0MB +1.0B
unifiedSearch 222.5KB 222.4KB -98.0B
total -97.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 419.3KB 419.6KB +291.0B
kbnUiSharedDeps-css 213.2KB 208.1KB -5.1KB
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +5.8KB
kbnUiSharedDeps-srcJs 3.3MB 3.3MB -1.0B
total +990.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 44ebd17 into elastic:main Aug 1, 2024
48 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 1, 2024
@cee-chen cee-chen deleted the eui/v95.5.0 branch August 1, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@peteharverson peteharverson peteharverson approved these changes

@wayneseymour wayneseymour wayneseymour approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
apm:review backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.