[Infra] apm_data_access service to return host names #189894
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
force-pushed
the
188752-get-hostnames-from-apm
branch
from
15b1783
to
d10aa85
Compare
|
/ci |
crespocarlos
changed the title
crespocarlos
changed the title
crespocarlos
force-pushed
the
188752-get-hostnames-from-apm
branch
from
d10aa85
to
7075748
Compare
crespocarlos
added
Team:obs-ux-infra_services
| return async ({ start, end, size = MAX_SIZE, query, documentSources }: HostNamesRequest) => { | ||
| const sourcesToUse = getPreferredBucketSizeAndDataSource({ | ||
| sources: documentSources.filter((s) => suitableTypes.includes(s.documentType)), | ||
| bucketSizeInSeconds: getBucketSize({ start, end, numBuckets: 50 }).bucketSize, |
There was a problem hiding this comment.
should this be (end - start) * 1000?
There was a problem hiding this comment.
makes sense. thanks
There was a problem hiding this comment.
I had to revert this change, with (end - start) * 1000, getPreferredBucketSizeAndDataSource was returning the wrong rollupInterval (10m instead of 1m) with 15m range
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
closes #188752
Summary
This PR creates a service that will return host names collected by APM.
NOTE: At first, we'll use this service to join the host names from APM with metrics collected by the system module to build the hosts with metrics lists - not necessarily to be used in the total hosts count functionality. This service may be adjusted as we start using it in Infra.