[FTR] enable recommended mocha + no-floating-promises ESLint rules

.eslintrc.js

@@ -1365,6 +1365,25 @@ module.exports = {
         'react/jsx-fragments': 'error',
       },
     },
+    {
+      files: [
+        'test/{accessibility,*functional*,*api_integration*}/apps/**/*.{js,ts}',
+        'x-pack/test/{accessibility,*functional*,*api_integration*}/apps/**/*.{js,ts}',
+        'x-pack/test_serverless/{functional,api_integration}/test_suites/**/*.{js,ts}',
+      ],
+      extends: ['plugin:mocha/recommended'],
+      plugins: ['mocha'],
+      env: {
+        mocha: true,
+      },
+      rules: {
+        'mocha/no-mocha-arrows': 'off',
+        'mocha/no-exports': 'off',
+        'mocha/no-setup-in-describe': 'off',
+        'mocha/no-nested-tests': 'off',
+        'mocha/no-skipped-tests': 'off',
+      },
+    },
     {
       files: ['x-pack/plugins/lists/public/**/!(*.test).{js,mjs,ts,tsx}'],
       plugins: ['react-perf'],

packages/core/application/core-application-browser-internal/integration_tests/application_service.test.tsx

@@ -159,7 +159,7 @@ describe('ApplicationService', () => {
 
         await act(async () => {
           await navigateToApp('app1');
-          update();
+          await update();
         });
 
         expect(currentAppIds).toEqual(['app1']);
@@ -195,15 +195,15 @@ describe('ApplicationService', () => {
 
         await act(async () => {
           await navigateToApp('app1');
-          update();
+          await update();
         });
         await act(async () => {
           await navigateToApp('app2', { path: '/nested' });
-          update();
+          await update();
         });
         await act(async () => {
           await navigateToApp('app2', { path: '/another-path' });
-          update();
+          await update();
         });
 
         expect(locations).toEqual(['/', '/app/app1', '/app/app2/nested', '/app/app2/another-path']);
@@ -625,9 +625,14 @@ describe('ApplicationService', () => {
         title: 'App1',
         mount: async ({ setHeaderActionMenu }: AppMountParameters) => {
           setHeaderActionMenu(mounter1);
-          promise.then(() => {
-            setHeaderActionMenu(mounter2);
-          });
+          promise
+            .then(() => {
+              setHeaderActionMenu(mounter2);
+            })
+            .catch((error) => {
+              // eslint-disable-next-line no-console
+              console.error('Error:', error);
+            });
           return () => undefined;
         },
       });
@@ -663,9 +668,14 @@ describe('ApplicationService', () => {
         title: 'App1',
         mount: async ({ setHeaderActionMenu }: AppMountParameters) => {
           setHeaderActionMenu(mounter1);
-          promise.then(() => {
-            setHeaderActionMenu(undefined);
-          });
+          promise
+            .then(() => {
+              setHeaderActionMenu(undefined);
+            })
+            .catch((error) => {
+              // eslint-disable-next-line no-console
+              console.error('Error:', error);
+            });
           return () => undefined;
         },
       });

src/dev/eslint/types.eslint.config.template.js

@@ -26,7 +26,7 @@ module.exports = {
   },
   overrides: [
     {
-      files: ['server/**/*'],
+      files: ['server/**/*', '*functional*/**/*', '*api_integration*/**/*'],
       rules: {
         // Let's focus on server-side errors first to avoid server crashes.
         // We'll tackle /public eventually.

test/accessibility/apps/dashboard.ts

@@ -20,7 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     const dashboardName = 'Dashboard Listing A11y';
     const clonedDashboardName = 'Dashboard Listing A11y (1)';
 
-    it('dashboard', async () => {
+    it('navitate to dashboard app', async () => {
       await PageObjects.common.navigateToApp('dashboard');
       await a11y.testAppSnapshot();
     });
@@ -61,7 +61,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await a11y.testAppSnapshot();
     });
 
-    it('Open Edit mode', async () => {
+    it('Open Edit mode again', async () => {
       await PageObjects.dashboard.switchToEditMode();
       await a11y.testAppSnapshot();
     });
@@ -86,7 +86,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await a11y.testAppSnapshot();
     });
 
-    it('Open add panel', async () => {
+    it('Open add panel again', async () => {
       await dashboardAddPanel.clickOpenAddPanel();
       await a11y.testAppSnapshot();
     });

test/accessibility/apps/management.ts

@@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await a11y.testAppSnapshot();
     });
 
-    describe('data views', async () => {
+    describe('data views', () => {
       before(async () => {
         await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
         await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');

test/api_integration/apis/data_views/fields_route/cache.ts

@@ -58,7 +58,7 @@ export default function ({ getService }: FtrProviderContext) {
       expect(response.get('vary')).to.equal('accept-encoding, user-hash');
       expect(response.get('etag')).to.not.be.empty();
 
-      kibanaServer.uiSettings.replace({ 'data_views:cache_max_age': 5 });
+      await kibanaServer.uiSettings.replace({ 'data_views:cache_max_age': 5 });
     });
 
     it('returns 304 on matching etag', async () => {

test/functional/apps/console/ace/_autocomplete.ts

@@ -8,7 +8,6 @@
 
 import _ from 'lodash';
 import expect from '@kbn/expect';
-import { asyncForEach } from '@kbn/std';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
@@ -17,6 +16,24 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const PageObjects = getPageObjects(['common', 'console', 'header']);
   const find = getService('find');
 
+  async function runTemplateTest(type: string, template: string) {
+    await PageObjects.console.enterText(`{\n\t"type": "${type}"`);
+    await PageObjects.console.pressEnter();
+    await PageObjects.console.sleepForDebouncePeriod();
+    // Prompt autocomplete for 'settings'
+    await PageObjects.console.promptAutocomplete('s');
+
+    await retry.waitFor('autocomplete to be visible', () =>
+      PageObjects.console.isAutocompleteVisible()
+    );
+    await PageObjects.console.pressEnter();
+    await retry.try(async () => {
+      const request = await PageObjects.console.getRequest();
+      log.debug(request);
+      expect(request).to.contain(`${template}`);
+    });
+  }
+
   describe('console autocomplete feature', function describeIndexTests() {
     this.tags('includeFirefox');
     before(async () => {
@@ -365,47 +382,27 @@ GET _search
       });
     });
 
-    describe('with conditional templates', async () => {
-      const CONDITIONAL_TEMPLATES = [
-        {
-          type: 'fs',
-          template: `"location": "path"`,
-        },
-        {
-          type: 'url',
-          template: `"url": ""`,
-        },
-        { type: 's3', template: `"bucket": ""` },
-        {
-          type: 'azure',
-          template: `"path": ""`,
-        },
-      ];
-
+    describe('with conditional templates', () => {
       beforeEach(async () => {
         await PageObjects.console.clearTextArea();
         await PageObjects.console.enterRequest('\n POST _snapshot/test_repo');
         await PageObjects.console.pressEnter();
       });
 
-      await asyncForEach(CONDITIONAL_TEMPLATES, async ({ type, template }) => {
-        it('should insert different templates depending on the value of type', async () => {
-          await PageObjects.console.enterText(`{\n\t"type": "${type}"`);
-          await PageObjects.console.pressEnter();
-          await PageObjects.console.sleepForDebouncePeriod();
-          // Prompt autocomplete for 'settings'
-          await PageObjects.console.promptAutocomplete('s');
+      it('should insert fs template', async () => {
+        await runTemplateTest('fs', `"location": "path"`);
+      });
 
-          await retry.waitFor('autocomplete to be visible', () =>
-            PageObjects.console.isAutocompleteVisible()
-          );
-          await PageObjects.console.pressEnter();
-          await retry.try(async () => {
-            const request = await PageObjects.console.getRequest();
-            log.debug(request);
-            expect(request).to.contain(`${template}`);
-          });
-        });
+      it('should insert url template', async () => {
+        await runTemplateTest('url', `"url": ""`);
+      });
+
+      it('should insert s3 template', async () => {
+        await runTemplateTest('s3', `"bucket": ""`);
+      });
+
+      it('should insert azure template', async () => {
+        await runTemplateTest('azure', `"path": ""`);
       });
     });
   });