Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ON-WEEK][POC] Playwright #190803
[ON-WEEK][POC] Playwright #190803
Changes from 53 commits
d3f7ac5
c7a3d6a
77b67fa
9224f2b
d07e114
95389df
31d5086
96cfb8c
5d42b62
3c54a46
7c21558
5787149
913cfcf
13a6d73
e566904
ca4759a
7595282
3510cd3
edeca9d
8065dfa
50aa417
bffa81c
da0b2ea
f06fd77
9bde417
3d93299
648ba44
3706b37
3cd3ae2
e1e2b3f
21817bb
957270b
38fe12c
52ef2b1
1368c3b
ca011de
30c38c7
c72f324
bdb983d
95579cb
6316f24
cdb8450
66458a0
7b1f9bf
616d1fd
6bbb612
22f5f27
31c9f18
7d8c87a
4d046a9
1012289
d69d4d2
dc1fd35
18adcda
a09a61b
aa81ff5
199c1b5
7c5e063
315a2e3
5bf48dc
a9893a5
f126e55
5163fdc
d679772
acb090e
484b4e0
beb50f1
9cf36d2
ee4c3b2
a4065b0
eb359e5
d3d232e
3064584
dcf5894
28dbdab
f3f00db
0dd92ff
384b470
7344b41
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this to
yarn kbn bootstrap
so it can be cached on CI, or use the already installed system browsers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbudz can you please point me out where/how to do so? I tried to do it myself in this commit but the test is failing, so I'm assuming I did it in the wrong way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: I found the issue that was making the test fail, was not related with those changes.
@jbudz would you mind giving another look at the PR? If I'm not mistaken I already addressed all your comments. Thanks! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of
set +e
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbudz I was replicating what we have in all our scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
set +e
allows the script to continue to the end of the run if errors are encountered. Normally a bash script will terminate immediately on the first error encountered.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed here? The only command run is
yarn run:serverless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it now.