Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Resolving color calculations testing branch #191801

Closed
wants to merge 26 commits into from
Closed

[DRAFT] Resolving color calculations testing branch #191801

wants to merge 26 commits into from

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Aug 30, 2024 •
edited
Loading

Important

This is only a testing branch and should not be merged.
This Draft PR is based of a non-merged EUI update PR to ensure parity. (Hence additional changes)

cee-chen and others added 23 commits August 23, 2024 15:28
@cee-chen
Upgrade EUI to v95.8.0
bc35445
@cee-chen
i18n updates
8d9b5fd
@cee-chen
Fix Enzyme tests that require more specific selectors
0fa43c7 
- caused by additional Emotion wrapper that matches the same selector
@cee-chen
Update Enzyme snapshots from EuiFormRow class->function component mig…
9673ce2 
…ration

- default props are no longer read/rendered by enzyme's snapshotter
@cee-chen
Update type from EuiFormRow class->function component migration
010cc30
@cee-chen
Fix test failures due to EuiFormRow switching from htmlIdGenerator …
9a3f1d3 
…to `useGeneratedHtmlId`

- requires updating mocks
@cee-chen
Update DOM snapshots from DOM changes/Emotion classNames
b30436a
@cee-chen
Fix test DOM selectors to account for updated DOM
71f670b 
- checkbox and radio inputs should now be directly clickable, and have a different DOM wrapper
@cee-chen
Delete/Update references to removed modifier classes
ccf1274
@cee-chen
Replace deprecated @euiFormLabel mixin
2dc43b0 
- use EuiTitle size and font weight instead
@cee-chen
Delete unused $euiSwitchWidth CSS
caf092e 
- `.spcShareToSpaceIncludeRelated` isn't actually used anywhere in Kibana
@cee-chen
Fix CSS selector
ce7bd2f 
- EuiCheckbox DOM has changed since, color: inherit should work for both disabled and non-disabled checkboxes
@cee-chen
Replace direct className usage of several deprecated Emotion conversi…
4e5d2bd 
…ons with components instead

- in the cast of the `prepend` prop, `<EuiFormLabel>` is already automatically used if the prepend type is a string
@cee-chen
[Unified Search] Remove direct className usage in favor of component
99d6b0d
@cee-chen
Remove direct form control append/prepend classNames
a368861 
- EuiFormControlLayout should automatically handle styling, and prepend/append nodes shouldn't be used outside of form layouts
@cee-chen
Replace EuiSwitch --mini direct className usage with prop
6766709
@cee-chen
Remove unnecessary hasEmptyLabelSpace prop within `EuiDescribedForm…
50bed3e 
…Group`s

- EuiDescribedFormGroups already automatically accounts for form rows without labels, so the `hasEmptyLabelSpace` prop is now unnecessary and adds extra unwanted spacing
@cee-chen
Merge branch 'main' into eui/v95.8.0
5a7f61d
@cee-chen
Upgrade to latest release
24c8fb5 
- contains all the backports + several requested new features from Kibana consumers
@cee-chen
Fix Dashboard controls custom CSS
ebce0ce 
- remove now-unnecessary unsets or importants

- tweak heights/vertical centering etc

- [feat] rewrite range slider CSS in Emotion vs Sass + with new CSS variables etc
@mbondyra
Merge branch 'main' into eui/v95.8.0
6872b4f
@cee-chen
[PR feedback] Fix visual regression by removing unnecessary EuiFormRow
db96596 
- doesn't apply and isn't necessary, removing it gets the button group back to the previous prod rendering
@mgadewoll
add EUI testing package for resolving color calculations
22ea34b
@mgadewoll mgadewoll added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Aug 30, 2024
@mgadewoll
Copy link
Contributor Author

buildkite test this

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 30, 2024 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / App renders properly
  • [job] [logs] Jest Tests #9 / Color Palette colorTransformer() should just work
  • [job] [logs] Jest Tests #3 / Core web vital config test should return expected json
  • [job] [logs] Jest Tests #3 / Core web vital config test should return expected json
  • [job] [logs] Jest Tests #3 / createLayerDescriptor apm data stream
  • [job] [logs] Jest Tests #3 / createLayerDescriptor apm data stream
  • [job] [logs] Jest Tests #3 / createLayerDescriptor apm index
  • [job] [logs] Jest Tests #3 / createLayerDescriptor apm index
  • [job] [logs] Jest Tests #3 / createLayerDescriptor non-apm index
  • [job] [logs] Jest Tests #3 / createLayerDescriptor non-apm index
  • [job] [logs] Jest Tests #9 / createTSVBLink() should change series to area
  • [job] [logs] Jest Tests #9 / createTSVBLink() should change series to area and stacked
  • [job] [logs] Jest Tests #9 / createTSVBLink() should just work
  • [job] [logs] Jest Tests #9 / createTSVBLink() should remove axis_min from link
  • [job] [logs] Jest Tests #9 / createTSVBLink() should use the workaround index pattern when there are multiple listed in the source
  • [job] [logs] Jest Tests #9 / createTSVBLink() should work with filterQuery
  • [job] [logs] Jest Tests #9 / createTSVBLink() should work with rates
  • [job] [logs] Jest Tests #9 / createTSVBLink() should work with time range
  • [job] [logs] FTR Configs #58 / dashboard app - group 3 dashboard state Overriding colors on an area chart is preserved
  • [job] [logs] FTR Configs #99 / dashboard app - group 6 dashboard snapshots compare controls snapshot in dark mode
  • [job] [logs] FTR Configs #50 / dashboard Reporting Dashboard Reporting Screenshots Sample data from Kibana 7.6 PNG file matches the baseline image
  • [job] [logs] FTR Configs #50 / dashboard Reporting Dashboard Reporting Screenshots Sample data from Kibana 7.6 PNG file matches the baseline image
  • [job] [logs] Jest Tests #6 / deserialize should deserialize fields
  • [job] [logs] Jest Tests #6 / deserialize should deserialize fields
  • [job] [logs] FTR Configs #16 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #77 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #80 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #93 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #93 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #16 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #80 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] FTR Configs #77 / discover/context_awareness extension getRowIndicatorProvider should render log.level row indicators
  • [job] [logs] Jest Tests #3 / dynamic ordinal predefined color ramp Should return center color from color ramp
  • [job] [logs] Jest Tests #3 / dynamic ordinal predefined color ramp Should return center color from color ramp
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette pre-defined color palette should return mapbox expression for color palette
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette pre-defined color palette should return mapbox expression for color palette
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp interpolate color ramp should return mapbox expression for color ramp
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp interpolate color ramp should return mapbox expression for color ramp
  • [job] [logs] Jest Tests #3 / getColorPalette Should create RGB color ramp
  • [job] [logs] Jest Tests #3 / getColorPalette Should create RGB color ramp
  • [job] [logs] Jest Tests #3 / getColorRampCenterColor Should get center color from color ramp
  • [job] [logs] Jest Tests #3 / getColorRampCenterColor Should get center color from color ramp
  • [job] [logs] Jest Tests #3 / getDescriptorWithUpdatedStyleProps When styles should revert to static styling Should convert dynamic styles to static styles when there are no next fields
  • [job] [logs] Jest Tests #3 / getDescriptorWithUpdatedStyleProps When styles should revert to static styling Should convert dynamic styles to static styles when there are no next fields
  • [job] [logs] Jest Tests #7 / getFillColor when using an EUI palette returns the expected fill color
  • [job] [logs] Jest Tests #7 / getFillColor when using an EUI palette returns the expected fill color when risk score is 100
  • [job] [logs] Jest Tests #7 / getFillColor when using an EUI palette returns the expected fill color when risk score is greater than 100
  • [job] [logs] Jest Tests #7 / getFillColor when using an EUI palette returns the expected fill color when risk score is less than zero
  • [job] [logs] Jest Tests #7 / getFillColor when using an EUI palette returns the expected fill color when risk score is zero
  • [job] [logs] Jest Tests #3 / getLayerIcon Layers with non-elasticsearch sources should display icon
  • [job] [logs] Jest Tests #3 / getLayerIcon Layers with non-elasticsearch sources should display icon
  • [job] [logs] Jest Tests #7 / getLogLevelColor should work correctly
  • [job] [logs] Jest Tests #3 / getOrdinalMbColorRampStops Should create color stops
  • [job] [logs] Jest Tests #3 / getOrdinalMbColorRampStops Should create color stops
  • [job] [logs] Jest Tests #3 / getOrdinalMbColorRampStops Should create inverted color stops
  • [job] [logs] Jest Tests #3 / getOrdinalMbColorRampStops Should create inverted color stops
  • [job] [logs] Jest Tests #3 / getOrdinalMbColorRampStops Should snap to end of color stops for identical range
  • [job] [logs] Jest Tests #3 / getOrdinalMbColorRampStops Should snap to end of color stops for identical range
  • [job] [logs] Jest Tests #3 / getPercentilesMbColorRampStops Should create color stops
  • [job] [logs] Jest Tests #3 / getPercentilesMbColorRampStops Should create color stops
  • [job] [logs] Jest Tests #10 / getSeriesAndDomain formats series timings
  • [job] [logs] Jest Tests #13 / getSeriesAndDomain formats series timings
  • [job] [logs] Jest Tests #13 / getSeriesAndDomain formats series timings
  • [job] [logs] Jest Tests #10 / getSeriesAndDomain handles series formatting when only total timing values are available
  • [job] [logs] Jest Tests #13 / getSeriesAndDomain handles series formatting when only total timing values are available
  • [job] [logs] Jest Tests #13 / getSeriesAndDomain handles series formatting when only total timing values are available
  • [job] [logs] FTR Configs #54 / InfraOps App Metrics UI Home page with metrics present sort nodes by descending value
  • [job] [logs] FTR Configs #56 / InfraOps App Metrics UI Home page with metrics present sort nodes by descending value
  • [job] [logs] FTR Configs #54 / InfraOps App Metrics UI Home page with metrics present sort nodes by descending value
  • [job] [logs] FTR Configs #56 / InfraOps App Metrics UI Home page with metrics present sort nodes by descending value
  • [job] [logs] FTR Configs #42 / lens app - group 2 lens datatable should show dynamic coloring feature for numeric columns
  • [job] [logs] FTR Configs #42 / lens app - group 2 lens datatable should show dynamic coloring feature for numeric columns
  • [job] [logs] FTR Configs #12 / lens app - group 4 lens chart data should render heatmap chart
  • [job] [logs] FTR Configs #12 / lens app - group 4 lens chart data should render heatmap chart
  • [job] [logs] FTR Configs #5 / lens app - group 5 lens heatmap should render heatmap chart with the temperature palette
  • [job] [logs] FTR Configs #8 / lens app - group 6 lens metric applies dynamic color
  • [job] [logs] FTR Configs #8 / lens app - group 6 lens metric applies dynamic color
  • [job] [logs] Jest Tests #7 / LogLevelBadge renders badge with color based on provided logLevel
  • [job] [logs] Jest Tests #14 / logsDataSourceProfileProvider getRowIndicator should return the correct color for a given log level
  • [job] [logs] FTR Configs #57 / machine learning - data frame analytics outlier detection creation iowa house prices edits the analytics job and displays it correctly in the job list
  • [job] [logs] FTR Configs #57 / machine learning - data frame analytics outlier detection creation iowa house prices edits the analytics job and displays it correctly in the job list
  • [job] [logs] Jest Tests #11 / ManageSpacePage allows a space to be created
  • [job] [logs] Jest Tests #11 / ManageSpacePage allows a space to be created
  • [job] [logs] Jest Tests #11 / ManageSpacePage sets calculated fields for existing spaces
  • [job] [logs] Jest Tests #11 / ManageSpacePage sets calculated fields for existing spaces
  • [job] [logs] Jest Tests #15 / map_config #getDestinationLayer it returns a destination layer
  • [job] [logs] Jest Tests #15 / map_config #getDestinationLayer it returns a destination layer for custom layer mapping
  • [job] [logs] Jest Tests #15 / map_config #getLayerList it returns the complete layerList for multiple indices
  • [job] [logs] Jest Tests #15 / map_config #getLayerList it returns the complete layerList for multiple indices with custom layer mapping
  • [job] [logs] Jest Tests #15 / map_config #getLayerList it returns the complete layerList with a source, destination, and line layer
  • [job] [logs] Jest Tests #15 / map_config #getLineLayer it returns a line layer
  • [job] [logs] Jest Tests #15 / map_config #getLineLayer it returns a line layer for custom layer mapping
  • [job] [logs] Jest Tests #15 / map_config #getSourceLayer it returns a source layer
  • [job] [logs] Jest Tests #15 / map_config #getSourceLayer it returns a source layer for custom layer mapping
  • [job] [logs] FTR Configs #61 / maps app mapbox styles should style circle layer as expected
  • [job] [logs] FTR Configs #61 / maps app mapbox styles should style circle layer as expected
  • [job] [logs] Jest Tests #10 / Palettes A colour palette comprising timing and mime type colours is correctly generated
  • [job] [logs] Jest Tests #13 / Palettes A colour palette comprising timing and mime type colours is correctly generated
  • [job] [logs] Jest Tests #13 / Palettes A colour palette comprising timing and mime type colours is correctly generated
  • [job] [logs] Jest Tests #7 / PromptPage renders as expected with additional scripts
  • [job] [logs] Jest Tests #7 / PromptPage renders as expected without additional scripts
  • [job] [logs] Jest Tests #11 / removes aria-label when instructed not to announce the space name
  • [job] [logs] Jest Tests #11 / removes aria-label when instructed not to announce the space name
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow categorical Should render categorical legend with breaks from color ramp
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow categorical Should render categorical legend with breaks from color ramp
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow ordinal Should render interpolate bands
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow ordinal Should render interpolate bands
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow ordinal Should render percentile bands
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow ordinal Should render percentile bands
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow ordinal Should render single band when interpolate range is 0
  • [job] [logs] Jest Tests #3 / renderLegendDetailRow ordinal Should render single band when interpolate range is 0
  • [job] [logs] Jest Tests #11 / renders with a space name entirely made of whitespace
  • [job] [logs] Jest Tests #11 / renders with a space name entirely made of whitespace
  • [job] [logs] Jest Tests #11 / renders without crashing
  • [job] [logs] Jest Tests #11 / renders without crashing
  • [job] [logs] Jest Tests #7 / ResetSessionPage renders as expected
  • [job] [logs] Jest Tests #7 / ResetSessionPage renders as expected with custom page title
  • [job] [logs] FTR Configs #26 / security app - login selector reset session page compare screenshot
  • [job] [logs] FTR Configs #26 / security app - login selector reset session page compare screenshot
  • [job] [logs] Jest Tests #3 / should render
  • [job] [logs] Jest Tests #3 / should render
  • [job] [logs] Jest Tests #3 / should render with no style fields
  • [job] [logs] Jest Tests #3 / should render with no style fields
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category [metrics]>worke
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category auditbeat
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category C2 CompilerThre
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category containerd
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category dockerd
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category elasticsearch
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category filebeat
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category metricbeat
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category node
  • [job] [logs] Jest Tests #10 / topn getCategoryColor returns correct color for category Other
  • [job] [logs] FTR Configs #93 / transform - creation - index pattern creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #93 / transform - creation - index pattern creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #97 / transform - creation - runtime mappings & saved search creation with runtime mappings batch transform with pivot configurations and runtime mappings navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #97 / transform - creation - runtime mappings & saved search creation with runtime mappings batch transform with pivot configurations and runtime mappings navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #82 / transform basic license transform - creation - index pattern creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #82 / transform basic license transform - creation - index pattern creation_index_pattern batch transform with terms+date_histogram groups and avg agg navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #21 / transform basic license transform - creation - runtime mappings & saved search creation with runtime mappings batch transform with pivot configurations and runtime mappings navigates through the wizard and sets all needed fields
  • [job] [logs] FTR Configs #21 / transform basic license transform - creation - runtime mappings & saved search creation with runtime mappings batch transform with pivot configurations and runtime mappings navigates through the wizard and sets all needed fields
  • [job] [logs] Jest Tests #15 / TriggerButton base version (no icons) should render the main label as red if missing
  • [job] [logs] Jest Tests #7 / UnauthenticatedPage renders as expected
  • [job] [logs] Jest Tests #7 / UnauthenticatedPage renders as expected with custom title
  • [job] [logs] Jest Tests #10 / Unified data table cell rendering renders bytes column correctly using _source when details is true
  • [job] [logs] Jest Tests #10 / Unified data table cell rendering renders bytes column correctly using fields when details is true
  • [job] [logs] Jest Tests #11 / updates identifier, initials and color when name is changed
  • [job] [logs] Jest Tests #11 / updates identifier, initials and color when name is changed
  • [job] [logs] Jest Tests #9 / UserAvatar should render EuiAvatar correctly without avatar data
  • [job] [logs] Jest Tests #7 / useUserProfileForm should initialise form with values from user profile
  • [job] [logs] Jest Tests #16 / VegaParser._setDefaultColors vega
  • [job] [logs] Jest Tests #16 / VegaParser._setDefaultColors vega
  • [job] [logs] Jest Tests #16 / VegaParser._setDefaultColors vegalite
  • [job] [logs] Jest Tests #16 / VegaParser._setDefaultColors vegalite
  • [job] [logs] Jest Tests #16 / VegaVisualizations VegaVisualization - basics should show vega graph (may fail in dev env)
  • [job] [logs] Jest Tests #16 / VegaVisualizations VegaVisualization - basics should show vega graph (may fail in dev env)
  • [job] [logs] Jest Tests #16 / VegaVisualizations VegaVisualization - basics should show vegalite graph and update on resize (may fail in dev env)
  • [job] [logs] Jest Tests #16 / VegaVisualizations VegaVisualization - basics should show vegalite graph and update on resize (may fail in dev env)
  • [job] [logs] FTR Configs #64 / visualize app visual builder Time Series Elastic charts should display correct chart data, label names and area colors for sum aggregation when split by terms
  • [job] [logs] FTR Configs #64 / visualize app visual builder Time Series Elastic charts should display correct chart data, label names and area colors for sum aggregation when split by terms

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mgadewoll mgadewoll closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgadewoll @kibana-ci @cee-chen @mbondyra