[Infra] Attempt to fix flaky test #192091

crespocarlos · 2024-09-04T13:58:10Z

fixes #191806

Summary

It was a weird problem that could only be reproduced by running the host_view test after the node_details test. The cause was that the synthtrace data was not fully cleaned in between tests

obltmachine · 2024-09-04T13:58:28Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kibanamachine · 2024-09-04T17:23:50Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6854

[❌] x-pack/test/functional/apps/infra/config.ts: 9/50 tests passed.

see run history

kibanamachine · 2024-09-05T12:32:16Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6863

[❌] x-pack/test/functional/apps/infra/config.ts: 0/50 tests passed.

see run history

crespocarlos · 2024-09-05T14:14:53Z

/ci

crespocarlos · 2024-09-05T14:22:32Z

packages/kbn-apm-synthtrace/src/lib/infra/infra_synthtrace_es_client.ts

-      'metricbeat-*',
-      'logs-*',


Note
These were not assigned to any metric type

crespocarlos · 2024-09-05T14:23:29Z

x-pack/test/functional/apps/infra/index.ts

      loadTestFile(require.resolve('./metrics_anomalies'));
      loadTestFile(require.resolve('./metrics_explorer'));
      loadTestFile(require.resolve('./node_details'));
      loadTestFile(require.resolve('./hosts_view'));
+      loadTestFile(require.resolve('./metrics_source_configuration'));


Note
This test is potentially dangerous because it changes the index pattern, which could affect al subsequent tests if it fails to return the data to the original state.

In this case, could you add a comment to the code alerting about that and stating that it is best to keep it last?

kibanamachine · 2024-09-05T15:06:56Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6869

[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed.

see run history

crespocarlos · 2024-09-05T16:55:55Z

x-pack/test/functional/apps/infra/metrics_source_configuration.ts

-    after(async () => kibanaServer.savedObjects.cleanStandardList());
+    before(async () =>
+      Promise.all([
+        esArchiver.load('x-pack/test/functional/es_archives/infra/alerts'),


Note
This test was 100% dependent on the previous test running the alert archive.

kibanamachine · 2024-09-05T17:46:47Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6872

[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed.

see run history

kibanamachine · 2024-09-05T19:45:28Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6875

[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed.

see run history

…osts_vew-test

crespocarlos · 2024-09-05T20:10:43Z

/ci

kibanamachine · 2024-09-05T21:09:14Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6876

[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed.

see run history

elasticmachine · 2024-09-06T07:54:51Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

tonyghiani

synthtrace change LGTM

cauemarcondes

LGTM

MiriamAparicio · 2024-09-06T09:52:23Z

x-pack/test/functional/apps/infra/node_details.ts

        await navigateToNodeDetails('host-1', 'host', {
          name: 'host-1',
        });

        await pageObjects.header.waitUntilLoadingHasFinished();
-        await pageObjects.timePicker.setAbsoluteRange(


What's the reason why we don't need to navigate to the date with data?

We're setting the date picker with the same information in the test cases.

MiriamAparicio

Thanks for fixing the tests, LGTM 🌟

kibana-ci · 2024-09-06T10:11:50Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: a1905e8
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192091-a1905e8c32c2

Failed CI Steps

Metrics [docs]

✅ unchanged

History

💚 Build #232314 succeeded aa65f57
💔 Build #232251 failed 828c7b3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2024-09-06T11:12:42Z

💔 All backports failed

Status	Branch	Result
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 192091

Questions ?

Please refer to the Backport tool documentation

fixes [elastic#191806](elastic#191806) ## Summary It was a weird problem that could only be reproduced by running the host_view test after the node_details test. The cause was that the synthtrace data was not fully cleaned in between tests

kibanamachine · 2024-09-30T14:48:25Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 192091 locally

kibanamachine · 2024-09-30T14:48:26Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 192091 locally

kibanamachine · 2024-10-01T14:49:14Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 192091 locally

kibanamachine · 2024-10-02T15:49:37Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 192091 locally

kibanamachine · 2024-10-03T16:49:11Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 192091 locally

kibanamachine · 2024-10-04T16:49:21Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 192091 locally

attempt to fix flaky test

9160263

crespocarlos force-pushed the 191806-unskip-hosts_vew-test branch from bfead39 to 9160263 Compare September 5, 2024 09:10

attempt to fix flaky test

828c7b3

crespocarlos commented Sep 5, 2024

View reviewed changes

load alert archive

6f7effb

crespocarlos commented Sep 5, 2024

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into 191806-unskip-h…

aa65f57

…osts_vew-test

crespocarlos marked this pull request as ready for review September 6, 2024 07:54

crespocarlos requested review from a team as code owners September 6, 2024 07:54

crespocarlos added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 labels Sep 6, 2024

crespocarlos added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Sep 6, 2024

tonyghiani approved these changes Sep 6, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 6, 2024

cauemarcondes approved these changes Sep 6, 2024

View reviewed changes

add comment

a1905e8

crespocarlos enabled auto-merge (squash) September 6, 2024 09:28

MiriamAparicio reviewed Sep 6, 2024

View reviewed changes

MiriamAparicio approved these changes Sep 6, 2024

View reviewed changes

crespocarlos merged commit 7ad92ba into elastic:main Sep 6, 2024
23 checks passed

crespocarlos deleted the 191806-unskip-hosts_vew-test branch September 6, 2024 11:48

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024

crespocarlos added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infra] Attempt to fix flaky test #192091

[Infra] Attempt to fix flaky test #192091

crespocarlos commented Sep 4, 2024 •

edited by kibanamachine

Loading

obltmachine commented Sep 4, 2024

kibanamachine commented Sep 4, 2024

kibanamachine commented Sep 5, 2024

crespocarlos commented Sep 5, 2024

crespocarlos Sep 5, 2024 •

edited

Loading

crespocarlos Sep 5, 2024

cauemarcondes Sep 6, 2024

kibanamachine commented Sep 5, 2024

crespocarlos Sep 5, 2024 •

edited

Loading

kibanamachine commented Sep 5, 2024

kibanamachine commented Sep 5, 2024

crespocarlos commented Sep 5, 2024

kibanamachine commented Sep 5, 2024

elasticmachine commented Sep 6, 2024

tonyghiani left a comment

cauemarcondes left a comment

MiriamAparicio Sep 6, 2024

crespocarlos Sep 6, 2024

MiriamAparicio left a comment

kibana-ci commented Sep 6, 2024 •

edited

Loading

kibanamachine commented Sep 6, 2024

kibanamachine commented Sep 30, 2024

kibanamachine commented Sep 30, 2024

kibanamachine commented Oct 1, 2024

kibanamachine commented Oct 2, 2024

kibanamachine commented Oct 3, 2024

kibanamachine commented Oct 4, 2024

[Infra] Attempt to fix flaky test #192091

[Infra] Attempt to fix flaky test #192091

Conversation

crespocarlos commented Sep 4, 2024 • edited by kibanamachine Loading

Summary

obltmachine commented Sep 4, 2024

🤖 GitHub comments

kibanamachine commented Sep 4, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6854

kibanamachine commented Sep 5, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6863

crespocarlos commented Sep 5, 2024

crespocarlos Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

crespocarlos Sep 5, 2024

Choose a reason for hiding this comment

cauemarcondes Sep 6, 2024

Choose a reason for hiding this comment

kibanamachine commented Sep 5, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6869

crespocarlos Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Sep 5, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6872

kibanamachine commented Sep 5, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6875

crespocarlos commented Sep 5, 2024

kibanamachine commented Sep 5, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6876

elasticmachine commented Sep 6, 2024

tonyghiani left a comment

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

MiriamAparicio Sep 6, 2024

Choose a reason for hiding this comment

crespocarlos Sep 6, 2024

Choose a reason for hiding this comment

MiriamAparicio left a comment

Choose a reason for hiding this comment

kibana-ci commented Sep 6, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

History

kibanamachine commented Sep 6, 2024

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Sep 30, 2024

kibanamachine commented Sep 30, 2024

kibanamachine commented Oct 1, 2024

kibanamachine commented Oct 2, 2024

kibanamachine commented Oct 3, 2024

kibanamachine commented Oct 4, 2024

crespocarlos commented Sep 4, 2024 •

edited by kibanamachine

Loading

crespocarlos Sep 5, 2024 •

edited

Loading

crespocarlos Sep 5, 2024 •

edited

Loading

kibana-ci commented Sep 6, 2024 •

edited

Loading