[8.15] [Automatic Import] Reproducible sampling of log entries (#191598) #192507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Release note
Automatic Import now performs reproducible sampling from the list of log
entries instead of just truncating them.
## Summary
When the user uploads a log sample that is too large for us to handle,
we would previously simply truncate it at `MaxLogsSampleRows` entries.
With this change, we perform a reproducible random sampling instead.
User notification remains the same ("truncated") for now (also it's also
translated into different languages).
This sampling process:
1. Keeps the first entry as-is for header detection.
2. Selects at random remaining entries from the list.
3. Shuffles the entries other than the first one (even if there are less
entries than `MaxLogsSampleRows`).
4. Is reproducible since the random seed is fixed.
**Sampling** allows us to extract more information from the
user-provided data compared to truncation, while **reproducibility** is
important to be able to provide customer support.
This brings us another step towards the implementation of
elastic/security-team#9844
### Risk Matrix
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Behaviour of `seedrandom` package changes in the future, breaking the
tests | Low | Low | This package is also already used in Kibana |
| Users misunderstand how the sampling works and upload non-anonymized
data expecting that only the first rows are sent to the LLM | Low | Low
| We should change the text in a future PR |
---------
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 444fc48)
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @ilyannn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation