Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry][Security Solution] Fix integration tests on branch 9.0 #192842

Merged
merged 4 commits into from
Sep 13, 2024
Merged

[Telemetry][Security Solution] Fix integration tests on branch 9.0 #192842

merged 4 commits into from
Sep 13, 2024

Conversation

szaffarano
Copy link
Contributor

@szaffarano szaffarano commented Sep 13, 2024 •
edited
Loading

Summary

Follow up of #192040 and #192624

The issue was while installing the agent policy because the endpoint package is not listed in the EPR for kibana 9+. The fix is to disable kibanaVersionCheck.

Checklist

@szaffarano szaffarano requested a review from a team as a code owner September 13, 2024 10:57
@szaffarano szaffarano added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Sep 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@szaffarano szaffarano mentioned this pull request Sep 13, 2024
Open
6 tasks
@szaffarano szaffarano changed the title [Telemetry][Security Solution] Fix integration tests for kibana 9 [Telemetry][Security Solution] Fix integration tests on branch 9.0 Sep 13, 2024
@szaffarano szaffarano enabled auto-merge (squash) September 13, 2024 13:32
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / FilterPopover renders empty label correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

JDKurma
JDKurma approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@JDKurma JDKurma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szaffarano szaffarano merged commit 9681b9d into main Sep 13, 2024
41 checks passed
@szaffarano szaffarano deleted the szaffarano/fix-tests-kbn-9 branch September 13, 2024 16:31
@kibanamachine kibanamachine added v9.0.0 backport:skip This commit does not require backporting labels Sep 13, 2024
@petrklapka petrklapka mentioned this pull request Sep 16, 2024
Closed
markov00 pushed a commit to markov00/kibana that referenced this pull request Sep 18, 2024
@szaffarano @markov00
[Telemetry][Security Solution] Fix integration tests on branch 9.0 (e…
2d25955 
…lastic#192842)

## Summary

Follow up of elastic#192040 and
elastic#192624

The issue was while installing the agent policy because the `endpoint`
package is not listed in the EPR for kibana 9+. The fix is to disable
`kibanaVersionCheck`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDKurma JDKurma JDKurma approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szaffarano @elasticmachine @kibana-ci @JDKurma @kibanamachine