Commits on Sep 13, 2024

1. [Security Solution] Fix some Prebuilt Rules Cypress tests not running… …

   … in CI (elastic#191978)
   
   **Resolves: elastic#192256
   
   ## Summary
   
   This PR re-enables two Cypress test files that didn't run on CI:
   `update_workflow.cy.ts` and `prebuilt_rules_preview.cy.ts`. It also
   fixes failing tests in `prebuilt_rules_preview.cy.ts`.
   
   ### Changes
   - Renamed `update_workflow.ts` -> `update_workflow.cy.ts`. It didn't run
   on CI because it wasn't picked up by a glob
   [here](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/package.json#L14).
    - `prebuilt_rules_preview.cy.ts`:
   - Moved `{ tags: ['@ess', '@serverless'] }` to the top-level `describe`
   block instead of having it in a variable that is used in every
   `describe`. Apparently the tool we use to parse tags doesn't recognize
   tags in variables anymore, so this test didn't run in either ESS or
   Serverless pipelines.
   - Removed `describe('All environments' ... ` wrappers since they don't
   add any value anymore. Didn't remove any actual tests.
   - Reverted a change from this
   [PR](elastic#181427) that added a
   backdrop to the modal which doesn't allow user to switch rules without
   closing the modal. We have a
   [test](https://github.com/elastic/kibana/blob/main/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/prebuilt_rules/prebuilt_rules_preview.cy.ts#L1182)
   that checks that such switching is possible and this test started to
   fail once I reactivated the test file.
   - Fixed selectors that grab filters in the Overview tab. The old ones
   stopped working. Probably because of a change to the filters component
   that is built by another team.
   
   #### Correct behaviour: Switching between rules with flyout open
   
   https://github.com/user-attachments/assets/da4a0902-657c-45fe-adc1-eb44ad0de798
   (cherry picked from commit c65c2ae)

   

   nikitaindik committed Sep 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9dc0703
   • Browse repository at this point

   Copy the full SHA

   9dc0703 View commit details

   Browse the repository at this point in the history