[Cloud Security] Fix GCP service account deployment copy-paste command #192959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orouz
added
release_note:skip
This was referenced Sep 15, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
seanrathier
approved these changes
Sep 16, 2024
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
orouz
added
v8.16.0
backport:version
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
elastic#192959) (cherry picked from commit a5a7f15)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
…command (#192959) (#193427) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Fix GCP service account deployment copy-paste command (#192959)](#192959) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Or Ouziel","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-16T13:38:42Z","message":"[Cloud Security] Fix GCP service account deployment copy-paste command (#192959)","sha":"a5a7f1554b731f98e51a18efccdbf6e771077144","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","v8.16.0","backport:version"],"title":"[Cloud Security] Fix GCP service account deployment copy-paste command","number":192959,"url":"#192959 Security] Fix GCP service account deployment copy-paste command (#192959)","sha":"a5a7f1554b731f98e51a18efccdbf6e771077144"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#192959 Security] Fix GCP service account deployment copy-paste command (#192959)","sha":"a5a7f1554b731f98e51a18efccdbf6e771077144"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Or Ouziel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
installing CSPM GCP on agentless shows the user a command to copy-paste (and plug in values), the command was slightly off which ended up triggering the service account deployment for projects and not organizations.
ORD_ID→ORG_IDORG_ID=... && ./script→ORG_ID=.. script.ts- this is required to make the env variable available to the scriptlucky enough though, after testing the above changes, i ran into another issue on cloudbeat side, which prevented deployment all-together as
ORG_IDwas treated as a number instead of a string. see here