Add tooltips to Discover button icons #192963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sebelga
approved these changes
Sep 16, 2024
|
@jughosta thanks I totally missed that. It looks like there's some custom styles that break when you add tooltips to these buttons. I'll leave this open for now and pick it up in the future. |
|
@jughosta I updated this to only change the field list filter items. |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kibanamachine
added
v9.0.0
backport:skip
|
@smith Should this have a |
smith
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11076769498 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2024
## Summary When navigating through elements in Discover with a keyboard, icon-only buttons don't show their browser-native title attribute when focused, only when hovered. This makes it unclear when you "tab in to" an icon-only button what the button does. These changes add a tooltip on the filter in/out buttons on the field list values. | Before | After | | :----------: | :----------: | |  | | ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) (cherry picked from commit c12c361)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Add tooltips to Discover button icons (#192963)](#192963) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan L Smith","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-17T21:32:33Z","message":"Add tooltips to Discover button icons (#192963)\n\n## Summary\r\n\r\nWhen navigating through elements in Discover with a keyboard, icon-only\r\nbuttons don't show their browser-native title attribute when focused,\r\nonly when hovered.\r\n\r\nThis makes it unclear when you \"tab in to\" an icon-only button what the\r\nbutton does.\r\n\r\nThese changes add a tooltip on the filter in/out buttons on the field\r\nlist values.\r\n\r\n| Before | After |\r\n| :----------: | :----------: |\r\n| \r\n|\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"c12c361f5636791999345bc119b60139976bdd13","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"Add tooltips to Discover button icons","number":192963,"url":"https://github.com/elastic/kibana/pull/192963","mergeCommit":{"message":"Add tooltips to Discover button icons (#192963)\n\n## Summary\r\n\r\nWhen navigating through elements in Discover with a keyboard, icon-only\r\nbuttons don't show their browser-native title attribute when focused,\r\nonly when hovered.\r\n\r\nThis makes it unclear when you \"tab in to\" an icon-only button what the\r\nbutton does.\r\n\r\nThese changes add a tooltip on the filter in/out buttons on the field\r\nlist values.\r\n\r\n| Before | After |\r\n| :----------: | :----------: |\r\n| \r\n|\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"c12c361f5636791999345bc119b60139976bdd13"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192963","number":192963,"mergeCommit":{"message":"Add tooltips to Discover button icons (#192963)\n\n## Summary\r\n\r\nWhen navigating through elements in Discover with a keyboard, icon-only\r\nbuttons don't show their browser-native title attribute when focused,\r\nonly when hovered.\r\n\r\nThis makes it unclear when you \"tab in to\" an icon-only button what the\r\nbutton does.\r\n\r\nThese changes add a tooltip on the filter in/out buttons on the field\r\nlist values.\r\n\r\n| Before | After |\r\n| :----------: | :----------: |\r\n| \r\n|\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"c12c361f5636791999345bc119b60139976bdd13"}}]}] BACKPORT--> Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When navigating through elements in Discover with a keyboard, icon-only buttons don't show their browser-native title attribute when focused, only when hovered.
This makes it unclear when you "tab in to" an icon-only button what the button does.
These changes add a tooltip on the filter in/out buttons on the field list values.
Checklist