[Security Solution] - fix Cypress not running locally #193622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
PhilippeOberti
added
backport
release_note:skip
michaelolo24
approved these changes
Sep 20, 2024
janmonschke
approved these changes
Sep 20, 2024
PhilippeOberti
force-pushed
the
fix-security-solution-cypress
branch
from
ce9caa7
to
6a01a36
Compare
PhilippeOberti
force-pushed
the
fix-security-solution-cypress
branch
from
6a01a36
to
8b03a36
Compare
vgomez-el
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
LGTM! thanks @PhilippeOberti and @michaelolo24 for the fix!
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
(cherry picked from commit f6c5dd9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
…#193788) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] - fix Cypress not running locally (#193622)](#193622) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T19:22:11Z","message":"[Security Solution] - fix Cypress not running locally (#193622)","sha":"f6c5dd99c6d67e0ba7846e262a1ef401d3e37f03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","v8.16.0"],"title":"[Security Solution] - fix Cypress not running locally","number":193622,"url":"https://github.com/elastic/kibana/pull/193622","mergeCommit":{"message":"[Security Solution] - fix Cypress not running locally (#193622)","sha":"f6c5dd99c6d67e0ba7846e262a1ef401d3e37f03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193622","number":193622,"mergeCommit":{"message":"[Security Solution] - fix Cypress not running locally (#193622)","sha":"f6c5dd99c6d67e0ba7846e262a1ef401d3e37f03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Cypress not working when ran locally (and the error seems to also happen on Buildkite).
What happened
During on-week back in mid August, the Threat Intelligence Cypress tests were moved to the
security_solution_cypressfolder and all the tests were enabled again. The PR was only merged 3 weeks later, on the 10th of September. In between, another PR was merged, then reverted then merged again.I'm not sure exactly how these PRs impacted each other...
This PR fixes the issue with Cypress not working while keeping the Threat Intelligence Cypress tests (and all the other ones obviously) working! 😄 Thank you @michaelolo24 for providing the code to fix the issue!