Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add visuals to the Build dashboard pages #194234

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

wajihaparvez
Copy link
Contributor

@wajihaparvez wajihaparvez commented Sep 26, 2024

Summary

Added screenshots and gifs to the Build Dashboards pages as part of the ongoing project to add more visuals to the Dashboards docs.

Rel:https://github.com/elastic/platform-docs-team/issues/457 and https://github.com/elastic/platform-docs-team/issues/466

@wajihaparvez wajihaparvez added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Sep 26, 2024
@wajihaparvez wajihaparvez self-assigned this Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this is very nice!! And thanks for keeping improving the content 🚀

Comment on lines 126 to 128
+
[role="screenshot"]
image::images/control-settings-flyout-8.15.0.png[Control settings flyout, width=50%]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+
[role="screenshot"]
image::images/control-settings-flyout-8.15.0.png[Control settings flyout, width=50%]

I don't think this one adds much value, it just repeats the list we just provided above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Removing

@wajihaparvez wajihaparvez enabled auto-merge (squash) September 27, 2024 17:45
@wajihaparvez wajihaparvez merged commit dab2786 into elastic:main Sep 27, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11075769330

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
## Summary

Added screenshots and gifs to the [Build
Dashboards](https://www.elastic.co/guide/en/kibana/master/create-dashboards.html)
pages as part of the ongoing project to add more visuals to the
Dashboards docs.

Rel:elastic/platform-docs-team#457 and
elastic/platform-docs-team#466
(cherry picked from commit dab2786)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 27, 2024
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Docs] Add visuals to the Build dashboard pages
(#194234)](#194234)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"wajihaparvez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T18:23:24Z","message":"[Docs]
Add visuals to the Build dashboard pages (#194234)\n\n##
Summary\r\n\r\nAdded screenshots and gifs to the
[Build\r\nDashboards](https://www.elastic.co/guide/en/kibana/master/create-dashboards.html)\r\npages
as part of the ongoing project to add more visuals to the\r\nDashboards
docs.\r\n\r\nRel:elastic/platform-docs-team#457
and\r\nhttps://github.com/elastic/platform-docs-team/issues/466","sha":"dab27867a63476f1ca109efbbc18b33ea70e5d4a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[Docs]
Add visuals to the Build dashboard
pages","number":194234,"url":"https://github.com/elastic/kibana/pull/194234","mergeCommit":{"message":"[Docs]
Add visuals to the Build dashboard pages (#194234)\n\n##
Summary\r\n\r\nAdded screenshots and gifs to the
[Build\r\nDashboards](https://www.elastic.co/guide/en/kibana/master/create-dashboards.html)\r\npages
as part of the ongoing project to add more visuals to the\r\nDashboards
docs.\r\n\r\nRel:elastic/platform-docs-team#457
and\r\nhttps://github.com/elastic/platform-docs-team/issues/466","sha":"dab27867a63476f1ca109efbbc18b33ea70e5d4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194234","number":194234,"mergeCommit":{"message":"[Docs]
Add visuals to the Build dashboard pages (#194234)\n\n##
Summary\r\n\r\nAdded screenshots and gifs to the
[Build\r\nDashboards](https://www.elastic.co/guide/en/kibana/master/create-dashboards.html)\r\npages
as part of the ongoing project to add more visuals to the\r\nDashboards
docs.\r\n\r\nRel:elastic/platform-docs-team#457
and\r\nhttps://github.com/elastic/platform-docs-team/issues/466","sha":"dab27867a63476f1ca109efbbc18b33ea70e5d4a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: wajihaparvez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants