Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix file upload when pipeline is used #194273

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 27, 2024

Fixes bug introduced in #193744

If a file is uploaded with an ingest pipeline, the pipeline is created, but not used when uploading the data.

Adds tests to check that the data exists in the index and the expected fields exist and are populated.

@jgowdyelastic jgowdyelastic self-assigned this Sep 27, 2024
@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer Feature:File Upload v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Sep 27, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 27, 2024 12:44
@jgowdyelastic jgowdyelastic requested review from a team as code owners September 27, 2024 12:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed the import works when a pipeline is (or isn't) used.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 6fd1913 into elastic:main Sep 27, 2024
22 checks passed
@jgowdyelastic jgowdyelastic deleted the fix-file-upload-with-pipeline branch September 27, 2024 17:31
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11075110939

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
Fixes bug introduced in elastic#193744

If a file is uploaded with an ingest pipeline, the pipeline is created,
but not used when uploading the data.

Adds tests to check that the data exists in the index and the expected
fields exist and are populated.

(cherry picked from commit 6fd1913)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 27, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Fix file upload when pipline is used
(#194273)](#194273)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T17:31:47Z","message":"[ML]
Fix file upload when pipline is used (#194273)\n\nFixes bug introduced
in https://github.com/elastic/kibana/pull/193744\r\n\r\nIf a file is
uploaded with an ingest pipeline, the pipeline is created,\r\nbut not
used when uploading the data.\r\n\r\nAdds tests to check that the data
exists in the index and the expected\r\nfields exist and are
populated.","sha":"6fd19137fe1cb0293ce84f3bba8f8ae7fedd98c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:File
and Index Data Viz","Feature:File
Upload","v9.0.0","v8.16.0","backport:version"],"title":"[ML] Fix file
upload when pipline is
used","number":194273,"url":"https://github.com/elastic/kibana/pull/194273","mergeCommit":{"message":"[ML]
Fix file upload when pipline is used (#194273)\n\nFixes bug introduced
in https://github.com/elastic/kibana/pull/193744\r\n\r\nIf a file is
uploaded with an ingest pipeline, the pipeline is created,\r\nbut not
used when uploading the data.\r\n\r\nAdds tests to check that the data
exists in the index and the expected\r\nfields exist and are
populated.","sha":"6fd19137fe1cb0293ce84f3bba8f8ae7fedd98c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194273","number":194273,"mergeCommit":{"message":"[ML]
Fix file upload when pipline is used (#194273)\n\nFixes bug introduced
in https://github.com/elastic/kibana/pull/193744\r\n\r\nIf a file is
uploaded with an ingest pipeline, the pipeline is created,\r\nbut not
used when uploading the data.\r\n\r\nAdds tests to check that the data
exists in the index and the expected\r\nfields exist and are
populated.","sha":"6fd19137fe1cb0293ce84f3bba8f8ae7fedd98c9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
@walterra walterra changed the title [ML] Fix file upload when pipline is used [ML] Fix file upload when pipeline is used Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:File and Index Data Viz ML file and index data visualizer Feature:File Upload :ml release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants