Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: use GH app to deploy my kibana PRs #195354

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 8, 2024

Summary

Uses https://github.com/elastic/oblt-actions/tree/v1/oblt-cli/deploy-my-kibana since the elastic/apm-pipeline-library is deprecated and we replaced finer-grained/PAT GH tokens for ephemeral tokens.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@v1v v1v added release_note:skip Skip the PR/issue when compiling release notes skip-ci backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development labels Oct 8, 2024
@v1v v1v self-assigned this Oct 8, 2024
@v1v v1v requested review from a team as code owners October 8, 2024 08:09
@v1v v1v merged commit a7be9cf into elastic:main Oct 8, 2024
16 checks passed
@v1v v1v deleted the feature/use-ephemeral-token-deploy-my-kibana branch October 8, 2024 12:35
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11235545375

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 8, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 8, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 8, 2024
…195400)

# Backport

This will backport the following commits from `main` to `8.15`:
- [github-actions: use GH app to deploy my kibana PRs
(#195354)](#195354)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T12:35:38Z","message":"github-actions:
use GH app to deploy my kibana PRs
(#195354)","sha":"a7be9cf44f0005b18cdefa2f4b54f0449a6e6cb5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","skip-ci","backport:prev-major"],"title":"github-actions:
use GH app to deploy my kibana
PRs","number":195354,"url":"https://github.com/elastic/kibana/pull/195354","mergeCommit":{"message":"github-actions:
use GH app to deploy my kibana PRs
(#195354)","sha":"a7be9cf44f0005b18cdefa2f4b54f0449a6e6cb5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195354","number":195354,"mergeCommit":{"message":"github-actions:
use GH app to deploy my kibana PRs
(#195354)","sha":"a7be9cf44f0005b18cdefa2f4b54f0449a6e6cb5"}}]}]
BACKPORT-->

Co-authored-by: Victor Martinez <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 8, 2024
…195401)

# Backport

This will backport the following commits from `main` to `8.x`:
- [github-actions: use GH app to deploy my kibana PRs
(#195354)](#195354)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T12:35:38Z","message":"github-actions:
use GH app to deploy my kibana PRs
(#195354)","sha":"a7be9cf44f0005b18cdefa2f4b54f0449a6e6cb5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","skip-ci","backport:prev-major"],"title":"github-actions:
use GH app to deploy my kibana
PRs","number":195354,"url":"https://github.com/elastic/kibana/pull/195354","mergeCommit":{"message":"github-actions:
use GH app to deploy my kibana PRs
(#195354)","sha":"a7be9cf44f0005b18cdefa2f4b54f0449a6e6cb5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195354","number":195354,"mergeCommit":{"message":"github-actions:
use GH app to deploy my kibana PRs
(#195354)","sha":"a7be9cf44f0005b18cdefa2f4b54f0449a6e6cb5"}}]}]
BACKPORT-->

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development release_note:skip Skip the PR/issue when compiling release notes skip-ci v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants