Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate save top nav in Discover and Visualize to EUI #23190

Merged
merged 12 commits into from
Sep 20, 2018
Merged

Migrate save top nav in Discover and Visualize to EUI #23190

merged 12 commits into from
Sep 20, 2018

Commits on Sep 13, 2018

  1. extract reusable save component from DashboardSaveModal

    @nreese
    nreese committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    53e8189 View commit details
    Browse the repository at this point in the history

  2. update discover search to use SavedObjectSaveModal

    @nreese
    nreese committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    e60c15b View commit details
    Browse the repository at this point in the history

  3. create generic show_save_model that works for both discover and dashb… 

    …oard
    @nreese
    nreese committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    ecb79a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. fix last bits of discover save

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    834e436 View commit details
    Browse the repository at this point in the history

  2. remove old save functionallity

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    52b00e5 View commit details
    Browse the repository at this point in the history

  3. migrate visualize save to EUI

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    71350dc View commit details
    Browse the repository at this point in the history

  4. fix functional tests

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    e8be1d1 View commit details
    Browse the repository at this point in the history

  5. disable save button if title is empty

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    b3d0d62 View commit details
    Browse the repository at this point in the history

  6. mark title input as invalid when title is not provided

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    91a98fc View commit details
    Browse the repository at this point in the history

  7. fix funtional tests

    @nreese
    nreese committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    8d2afab View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. merge with master

    @nreese
    nreese committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    57fcc43 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Merge branch 'master' of github.com:elastic/kibana into eui_save

    @nreese
    nreese committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    fc64fb9 View commit details
    Browse the repository at this point in the history