-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user email validation #23346
user email validation #23346
Conversation
💔 Build Failed |
💚 Build Succeeded |
jenkins, test this |
💔 Build Failed |
jenkins, test this |
💚 Build Succeeded |
jenkins, test this |
💔 Build Failed |
jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have an additional comment. There should probably be some condition that you wait for at the end of changePassword. Basically, the way it is now, the tests might have the tendency to be flaky because there are no waits, nor retries. So if something isn't ready, it will just fail.
💚 Build Succeeded |
jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after removing the duplicate test
expect(users.anonymous.reserved).to.be(true); | ||
} | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is already in x-pack/test/functional/apps/security/users.js:
. I think you started from that file and forgot to take this out?
jenkins, test this |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
* Added automation for a support-dev-help ticket - user email validation https://github.com/elastic/support-dev-help/issues/4571
* Added automation for a support-dev-help ticket - user email validation elastic/support-dev-help#4571
* Added automation for a support-dev-help ticket - user email validation https://github.com/elastic/support-dev-help/issues/4571
data-test-subj
where ever required.in support of a SDH ticket opened a while back.