Normalize path for comparison on Windows #23404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
added
review
Team:Operations
|
I can confirm this fixes the fatal start-up error that was happening before on Windows. |
|
retest |
1 similar comment
|
retest |
This comment has been minimized.
This comment has been minimized.
tylersmalley
force-pushed
the
fix-windows-path
branch
from
cb23ca2
to
8d55dd9
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
fix-windows-path
branch
from
8d55dd9
to
25ee15c
Compare
This comment has been minimized.
This comment has been minimized.
|
retest |
This comment has been minimized.
This comment has been minimized.
|
retest |
💚 Build Succeeded |
tylersmalley
added a commit
that referenced
this pull request
Sep 24, 2018
Signed-off-by: Tyler Smalley <[email protected]>
|
6.x/6.5: b3778f9 |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Sep 25, 2018
Signed-off-by: Tyler Smalley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're checking that the styleSheetPath is within the publicPath, we need to normalize the path to align with how the publicPath is represented.