-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Translate Agg_types(part_1) #24259
Merged
Nox911
merged 35 commits into
elastic:master
from
Nox911:feature/translate-ui-agg_types-buckets
Nov 26, 2018
Merged
[i18n] Translate Agg_types(part_1) #24259
Nox911
merged 35 commits into
elastic:master
from
Nox911:feature/translate-ui-agg_types-buckets
Nov 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
💔 Build Failed |
retest |
1 similar comment
retest |
maryia-lapata
added
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
Project:i18n
v6.6.0
labels
Oct 24, 2018
timroes
added
the
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
label
Oct 27, 2018
Jenkins, test this |
💔 Build Failed |
💔 Build Failed |
retest |
Nox911
changed the title
Feature/translate ui-agg_types-buckets
[i18n] Translate Agg_types(part_2)
Nov 22, 2018
Nox911
changed the title
[i18n] Translate Agg_types(part_2)
[i18n] Translate Agg_types(part_1)
Nov 22, 2018
💚 Build Succeeded |
timroes
suggested changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor parameter name requests.
💔 Build Failed |
timroes
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 26, 2018
* translate ui-agg_types-bucket * Fix name of id * Delete extra i18n import * Rename some parameters
Nox911
pushed a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
Project:i18n
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v6.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate ui -> agg_types -> buckets