Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Translate Agg_types(part_1) #24259

Merged
merged 35 commits into from
Nov 26, 2018
Merged

[i18n] Translate Agg_types(part_1) #24259

merged 35 commits into from
Nov 26, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Oct 19, 2018

translate ui -> agg_types -> buckets

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Oct 22, 2018

retest

1 similar comment
@Nox911
Copy link
Contributor Author

Nox911 commented Oct 22, 2018

retest

@maryia-lapata maryia-lapata added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:i18n v6.6.0 labels Oct 24, 2018
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 27, 2018
@timroes
Copy link
Contributor

timroes commented Oct 27, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911 Nox911 mentioned this pull request Nov 22, 2018
Merged
@Nox911 Nox911 added the review label Nov 22, 2018
@Nox911
Copy link
Contributor Author

Nox911 commented Nov 22, 2018

retest

@Nox911 Nox911 changed the title Feature/translate ui-agg_types-buckets [i18n] Translate Agg_types(part_2) Nov 22, 2018
@Nox911 Nox911 changed the title [i18n] Translate Agg_types(part_2) [i18n] Translate Agg_types(part_1) Nov 22, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 requested a review from timroes November 23, 2018 08:30
@Nox911 Nox911 mentioned this pull request Nov 23, 2018
Merged
timroes
timroes suggested changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor parameter name requests.

src/ui/public/agg_types/buckets/date_histogram.js Outdated Show resolved Hide resolved
src/ui/public/agg_types/buckets/ip_range.js Outdated Show resolved Hide resolved
src/ui/public/agg_types/buckets/range.js Outdated Show resolved Hide resolved
src/ui/public/agg_types/buckets/range.js Outdated Show resolved Hide resolved
src/ui/public/agg_types/buckets/significant_terms.js Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

timroes
timroes approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 8f871f9 into elastic:master Nov 26, 2018
@Nox911 Nox911 deleted the feature/translate-ui-agg_types-buckets branch November 26, 2018 14:34
@Nox911 Nox911 removed the review label Nov 26, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Nov 26, 2018
@Nox911 @maryia-lapata
[i18n] Translate Agg_types(part_1) (elastic#24259)
83c9dfb 
* translate ui-agg_types-bucket

* Fix name of id

* Delete extra i18n import

* Rename some parameters
@maryia-lapata maryia-lapata mentioned this pull request Nov 26, 2018
Merged
Nox911 pushed a commit that referenced this pull request Nov 27, 2018
@maryia-lapata @Nox911
[i18n] Translate Agg_types(part_1) (#24259) (#26178)
9016da0 
* translate ui-agg_types-bucket

* Fix name of id

* Delete extra i18n import

* Rename some parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@pavel06081991 pavel06081991 pavel06081991 approved these changes

Assignees
No one assigned
Labels
backported Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:i18n Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nox911 @elasticmachine @timroes @pavel06081991 @maryia-lapata