Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git dir discovery into the precommit hook setup #25870

Merged
merged 4 commits into from
Nov 21, 2018
Merged

Fix git dir discovery into the precommit hook setup #25870

merged 4 commits into from
Nov 21, 2018

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 19, 2018

This is a small PR to fix an error reported in a previous merged PR #24887

@mistic mistic added review Team:Operations Team label for Operations Team v7.0.0 v6.6.0 labels Nov 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@mistic mistic mentioned this pull request Nov 19, 2018
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

weltenwort
weltenwort approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my setup 👍 I left a nitpicky naming suggestion in the inline comments.

Alternatively, couldn't we just promisify the simpleGit.revparse function and avoid the manual resolve/reject juggling?

src/dev/register_git_hook/register_git_hook.js Outdated Show resolved Hide resolved
src/dev/register_git_hook/register_git_hook.js Outdated Show resolved Hide resolved
src/dev/register_git_hook/register_git_hook.js Outdated Show resolved Hide resolved
@mistic
Copy link
Member Author

mistic commented Nov 20, 2018

@weltenwort before open the PR I tried to promisify the simpleGit.revparse function but it was failing so I haven't tried it more. I give it another shot and this time I make it work. Your suggestion is now applied to the PR and everything should work as expected 😃

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

weltenwort
weltenwort approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mistic mistic merged commit e8e05d8 into elastic:master Nov 21, 2018
@mistic mistic mentioned this pull request Nov 21, 2018
Merged
mistic added a commit to mistic/kibana that referenced this pull request Nov 21, 2018
@mistic
Fix git dir discovery into the precommit hook setup (elastic#25870)
709762f 
* fix(NA): git dir discovery into the precommt hook setup.

* refact(NA): promisify gitrevparse function.

* docs(NA): fix typo on comments
mistic added a commit that referenced this pull request Nov 21, 2018
@mistic
Fix git dir discovery into the precommit hook setup (#25870) (#25980)
d9b81ce 
* fix(NA): git dir discovery into the precommt hook setup.

* refact(NA): promisify gitrevparse function.

* docs(NA): fix typo on comments
@mistic
Copy link
Member Author

mistic commented Nov 21, 2018

6.x: d9b81ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@weltenwort weltenwort weltenwort approved these changes

@joshdover joshdover Awaiting requested review from joshdover

Assignees
No one assigned
Labels
review Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @tylersmalley @weltenwort