-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix git dir discovery into the precommit hook setup #25870
Fix git dir discovery into the precommit hook setup #25870
Conversation
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in my setup 👍 I left a nitpicky naming suggestion in the inline comments.
Alternatively, couldn't we just promisify
the simpleGit.revparse
function and avoid the manual resolve/reject juggling?
@weltenwort before open the PR I tried to |
💚 Build Succeeded |
…git-dir-discovery
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix!
💚 Build Succeeded |
* fix(NA): git dir discovery into the precommt hook setup. * refact(NA): promisify gitrevparse function. * docs(NA): fix typo on comments
6.x: d9b81ce |
This is a small PR to fix an error reported in a previous merged PR #24887