Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the missing alt tag for waffle node type switcher svgs #27070

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Adding the missing alt tag for waffle node type switcher svgs #27070

merged 2 commits into from
Dec 13, 2018

Conversation

bhavyarm
Copy link
Contributor

Fixing these errors on linter waffle_node_type_switcher.tsx:

      /Users/Desktop/jsx-kibana/kibana/x-pack/plugins/infra/public/components/waffle/waffle_node_type_switcher.tsx:37:11
      ERROR: 37:11  react-a11y-img-has-alt  <img> elements must have an non-empty alt attribute or use empty alt attribute as well as role='presentation' for decorative/presentational images. A reference for the presentation role can be found at https://www.w3.org/TR/wai-aria/roles#presentation.
      ERROR: 44:11  react-a11y-img-has-alt  <img> elements must have an non-empty alt attribute or use empty alt attribute as well as role='presentation' for decorative/presentational images. A reference for the presentation role can be found at https://www.w3.org/TR/wai-aria/roles#presentation.
      ERROR: 51:11  react-a11y-img-has-alt  <img> elements must have an non-empty alt attribute or use empty alt attribute as well as role='presentation' for decorative/presentational images. A reference for the presentation role can be found at https://www.w3.org/TR/wai-aria/roles#presentation.

@bhavyarm bhavyarm mentioned this pull request Dec 12, 2018
Merged
6 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Dec 12, 2018

We can add empty alt attributes here. The button already has a correct label and the image anyway role="presentation", in which case an empty alt="" would make more sense.

@bhavyarm
Copy link
Contributor Author

@timroes ok. Will change it. Thanks!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@bhavyarm bhavyarm merged commit 8ad6949 into elastic:master Dec 13, 2018
@bhavyarm bhavyarm mentioned this pull request Dec 13, 2018
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Dec 13, 2018
@bhavyarm
Adding the missing alt tag for waffle node type switcher svgs (elasti…
1e876f9 
…c#27070)

* adding the missing alt tag

* making alt attribute empty
bhavyarm added a commit that referenced this pull request Dec 13, 2018
@bhavyarm
Adding the missing alt tag for waffle node type switcher svgs (#27070) (
519f085 
#27122)

* adding the missing alt tag

* making alt attribute empty
@bhavyarm bhavyarm mentioned this pull request Dec 13, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
Project:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhavyarm @elasticmachine @timroes @weltenwort