Embed timepicker in query bar #29130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
force-pushed
the
feature/global-date-picker
branch
from
4ddacd3
to
0633052
Compare
💔 Build Failed |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 22, 2019
* replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * embed timepicker in query bar * flesh out date picker in query bar for maps app * wire up refresh config
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 23, 2019
* replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * embed timepicker in query bar * flesh out date picker in query bar for maps app * wire up refresh config
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 24, 2019
* replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * embed timepicker in query bar * flesh out date picker in query bar for maps app * wire up refresh config
nreese
added a commit
that referenced
this pull request
Jan 31, 2019
…er in Top Nav (#29235) * Embed timepicker in query bar (#29130) * replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * embed timepicker in query bar * flesh out date picker in query bar for maps app * wire up refresh config * fix bug with way update function called by watcher * get maps application functional tests working with new timepicker * remove some changes outside of scoped work * clean up typescript lint problems * fix query_bar I18n lint error * update query_bar jest test * grab some parts missing from one cherry-pick * pass dateRange to updateQueryAndDispatch when app state changes * use timefilter disable methods to hide timepicker from top naav * get selected refresh unit * use EuiSuperUpdate button * Fix responsive sizing of datepicker (#29) * set isDisabled on EuiSuperUpdateButton * review feedback * remove ts-ignore comment from defaultProps, fix query_bar snapshot * make new props optional * fighting with ts linter * do not include dateRangeFrom and dateRangeTo in isDirty when shoDateRange is not true * pull initial query from UI settings
1 task
nreese
added a commit
that referenced
this pull request
Feb 6, 2019
* replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * Embed timepicker in query bar (#29130) * replace kbnTimepicker directive with EuiSuperDatePicker * remove kbnTimepicker directive * remove bootstrap datepicker * embed timepicker in query bar * flesh out date picker in query bar for maps app * wire up refresh config * fix bug with way update function called by watcher * get maps application functional tests working with new timepicker * update setAbsoluteRange for EuiSuperDatePicker * replace setQuickTime with calls to setAbsoluteTime * remove open time picker button in discover empty results view * pass config values to super-date-picker directive * remove getPrettyDuration * clean up typescript lint problems * some functional test fixes * try something else to fix I18n problems * fix some more functional tests * update query_bar jest test * remove unused method in kbn_global_timepicker * do not import removed timepicker styles * remove mode from time state * remove mode from time_history interface * fix problem with ui_settings_defaults * fix failing TSVB functional test * another round to test fixes * more functional test changes * fixes for failing tests * add retry block to flaky tsvb test * styles/bootstrap_dark.less * fix functional tests * call fetch event even when times are the same * add retry around flaky tsvb test * fix timefilter jest test, attempt to fix another flaky functional test * revert emitting fetch outside of areTimePickerValsDifferent check * clean up time mode code that is no longer needed in dashboard * fix timefilter tests changed by timefilter emit revert
Bargs
added a commit
that referenced
this pull request
Feb 8, 2019
Updates discover, visualize, and dashboard to use the date picker added to the query bar in #29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Feb 8, 2019
…0171) Updates discover, visualize, and dashboard to use the date picker added to the query bar in elastic#29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Feb 8, 2019
…0171) Updates discover, visualize, and dashboard to use the date picker added to the query bar in elastic#29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 8, 2019
…0171) Updates discover, visualize, and dashboard to use the date picker added to the query bar in elastic#29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put EuiSuperDatePicker in QueryBar. Implement for maps application