Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reporting tests on 6.x #29666

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Jan 30, 2019

I am not sure why these tests are disabled in 6.x branch, would like to re-enable them if there is nothing blocking them from running. Is phantom still supported in 6.7?

Issue #29529

@liza-mae liza-mae self-assigned this Jan 30, 2019
@liza-mae liza-mae added the test label Jan 30, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor Author

Failing Test:
X-Pack Phantom API Reporting Tests.x-pack/test/reporting/api/bwc_existing_indexes·js.phantom BWC report generation into existing indexes existing 6_2 index multiple jobs posted

Error: expected 500 to equal 200
at Assertion.assert (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/immutable/kibana/node_modules/expect.js/index.js:96:13)
at Assertion.be.Assertion.equal (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/immutable/kibana/node_modules/expect.js/index.js:216:10)
at Assertion.(anonymous function) [as be] (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/immutable/kibana/node_modules/expect.js/index.js:69:24)
at Object.waitForJobToFinish (test/reporting/services/reporting_api.js:39:29)

Is this because it is not supported, the test needs fixing or a real failure?

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Jan 31, 2019

Phantom should still be supported in 6.7. I am not aware of any specific reasons those api tests shouldn't work.

cc @joelgriffith

@joelgriffith
Copy link
Contributor

There was an issue previously that broke these tests, I'll have to dig it up in history and find out what it was. I'll take a look and see!

@joelgriffith
Copy link
Contributor

#26789 is part of the work to re-enable the chromium ones after a functional breakage. @tsullivan do you recall the nature around why these tests broke? I'm fuzzy on the details since it's been a bit

@tsullivan
Copy link
Member

you recall the nature around why these tests broke

Much of it seemed be general flakiness: the tests staged a lot of concurrent reporting jobs, and in ESQueue, an instance of Kibana will claim whatever it can. I broke up the tests to only stage 2-3 jobs at a time.

Since this PR is needed, it looks like there was a missed backport

@joelgriffith
Copy link
Contributor

Is there anything I can do on this? I'm not sure entirely what needs to be backported, otherwise happy to do so

@tsullivan
Copy link
Member

@liza-mae can you change this to enable just the chromium tests? I think the Phantom tests might need some updates before they can be called fixed.

Phantom is not in master, that's one reason for 6.x and master being different.

@liza-mae
Copy link
Contributor Author

liza-mae commented Feb 5, 2019

Thanks @tsullivan I removed phantom tests.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@epixa epixa changed the base branch from 6.x to 6.7 February 6, 2019 13:21
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joelgriffith joelgriffith self-requested a review February 6, 2019 16:30
@liza-mae liza-mae merged commit 4b4e1de into elastic:6.7 Feb 6, 2019
@liza-mae liza-mae deleted the liza-fix/issue-29515 branch February 6, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants