Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUI 6.8.0 #29860

Merged
merged 2 commits into from
Feb 1, 2019
Merged

EUI 6.8.0 #29860

merged 2 commits into from
Feb 1, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 1, 2019

Summary

6.8.0

  • Changed flex-basis value on EuiPageBody for better cross-browser support (#1497)
  • Converted a number of components to support text localization (#1485)
  • Added a seconds option to the refresh interval selection in EuiSuperDatePicker (#1503)
  • Changed to conditionally render EuiModalBody if EuiConfirmModal has no children (#1505)

Bug fixes

  • Remove font-features setting on @euiFont mixin to prevent breaks in ACE editor (#1497)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@snide snide added the v7.0.0 label Feb 1, 2019
@snide
Copy link
Contributor Author

snide commented Feb 1, 2019

cc @bmcconaghy and @sqren since this will fix the issue with console.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Feb 1, 2019

@nreese Fails on maps because of the seconds change I assume. Wanna let me know to change here?

image

@nreese
Copy link
Contributor

nreese commented Feb 1, 2019

Just change the expects clause for test should update global Kibana refresh config to value stored with map

expect(kibanaRefreshConfig.interval).to.equal('1');
expect(kibanaRefreshConfig.units).to.equal('seconds');

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Feb 1, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit fafa9fa into elastic:master Feb 1, 2019
@snide snide deleted the eui/6.8.0 branch February 1, 2019 22:38
@snide snide mentioned this pull request Feb 1, 2019
snide added a commit to snide/kibana that referenced this pull request Feb 1, 2019
Upgrades Kibana's EUI dep.
snide added a commit that referenced this pull request Feb 4, 2019
Upgrades Kibana's EUI dep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants