EUI 6.10.0 & Background color fixes #30136
Conversation
cchaos
added
Team:Platform-Design
|
Pinging @elastic/kibana-design |
cchaos
force-pushed
the
background-color
branch
from
28139cd
to
d3affa7
Compare
💔 Build Failed |
There was a problem hiding this comment.
👍 Canvas looks good. It uses several different shades of background fill colors to differentiate the page/workarea, bottom bar, and side nav sections which is a situation that could afford some potential tweaking. However, that situation existed prior to this PR and nothing here has impacted it further.
|
Thanks @ryankeairns! |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
I did a scan of ML, but had trouble getting into Infra/Logs locally but I'm pretty familiar there and I think that code should be fine.
Everything looks OK. Only breaks I saw were in DSC when empty
I also think the dark mode bg setting is too dark, but that's something we'd change in EUI.
|
Yeah that discovery page was what I was talking about. Do you want to fix it on your end? |
|
@cchaos Yeah, don't let it hold this up. |
|
@cchaos 6.10.0 is out now and will fix the coloring. |
cchaos
force-pushed
the
background-color
branch
from
fe236f3
to
2b0bed4
Compare
cchaos
changed the title
|
Updated to 6.10.0 |
|
Got a verbal 👍 from @jasonrhodes for APM |
💚 Build Succeeded |
|
Tests are passing, gotta get this in so we can continue our work. |
💚 Build Succeeded |
|
Sorry for the late update @cchaos, but tested the ML edits, and all looks fine - standard and dark theme. |
|
Great, thanks @peteharverson ! |
💚 Build Succeeded |
6.10.0EuiPopoverandEuiColorPickerto pauseEuiOutsideClickDetectorin when not open (#1527)6.9.0EuiNavDrawer(#1524)app_ems.svg(#1517)Bug fixes
EuiPagebackground color to match body background color (#1513)EuiPagination(#1514)EuiSwitchwith generated ID from having its label announced by VoiceOver (#1519)EuiFilterButtonhandlingnumFilterswhen0was specified (#1510)Background fixes
This PR removes the white background placed on
.applicationand now allows the background color from thehtmlelement to show through.This means that most of the background hacks we put on can be taken off. However, we now have the opposite hacks where some apps need the full white background so these were added.
I'd like to get a thumbs up from the following plugins (tagging people I know instead of whole teams)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility