Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Correctly handle single-feature joins #30409

Merged
merged 2 commits into from
Feb 8, 2019
Merged

[Maps] Correctly handle single-feature joins #30409

merged 2 commits into from
Feb 8, 2019

Conversation

thomasneirynck
Copy link
Contributor

Closes #28790

@thomasneirynck thomasneirynck added v7.0.0 [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.2.0 labels Feb 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

nreese
nreese approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thomasneirynck
Copy link
Contributor Author

jenkins, test this

kindsun
kindsun approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thomasneirynck
Copy link
Contributor Author

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

failing on dashboard-test

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor

nreese commented Feb 7, 2019

failing on dashboard-test

I have seen that flaky test fail multiple times today

@thomasneirynck
Copy link
Contributor Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thomasneirynck thomasneirynck merged commit 37b5ba9 into elastic:master Feb 8, 2019
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Feb 8, 2019
@thomasneirynck
[Maps] Correctly handle single-feature joins (elastic#30409)
1d3f5aa
@thomasneirynck thomasneirynck mentioned this pull request Feb 8, 2019
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Feb 8, 2019
@thomasneirynck
[Maps] Correctly handle single-feature joins (elastic#30409)
16a06dd
@thomasneirynck thomasneirynck mentioned this pull request Feb 8, 2019
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Feb 8, 2019
@thomasneirynck
[Maps] Correctly handle single-feature joins (elastic#30409)
d7cb07a
@thomasneirynck thomasneirynck mentioned this pull request Feb 8, 2019
Merged
thomasneirynck added a commit that referenced this pull request Feb 8, 2019
@thomasneirynck
[Maps] Correctly handle single-feature joins (#30409) (#30471)
273549e
thomasneirynck added a commit that referenced this pull request Feb 8, 2019
@thomasneirynck
[Maps] Correctly handle single-feature joins (#30409) (#30470)
e82c94f
thomasneirynck added a commit that referenced this pull request Feb 8, 2019
@thomasneirynck
[Maps] Correctly handle single-feature joins (#30409) (#30469)
2f7a561
lukeelmers pushed a commit to lukeelmers/kibana that referenced this pull request Feb 8, 2019
@thomasneirynck @lukeelmers
[Maps] Correctly handle single-feature joins (elastic#30409)
4a7bca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@kindsun kindsun kindsun approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasneirynck @elasticmachine @nreese @kindsun