Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly passing saved filters and query to all response handlers #33026

Closed
wants to merge 2 commits into from
Closed

correctly passing saved filters and query to all response handlers #33026

wants to merge 2 commits into from

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 12, 2019

We had to revert #32749 because of flaky test failure #32965

This is a resubmit of those changes, including changes to re-run kibana-ciGroup12 20 times each build in order to help ensure that it's no longer flaky.

@spalger spalger added v7.0.0 Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.2.0 labels Mar 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Mar 13, 2019

More than anything I wanted to open this as a proof of flakiness, I don't particularly like that I "own" the PR though, so I'm going to close this and leave the branch on my fork so @ppisljar or @lukeelmers can pull it down and resubmit their own PR

git fetch [email protected]:spalger/kibana.git resubmit/32749
git co -b resubmit/32749 FETCH_HEAD
git push origin

@spalger spalger closed this Mar 13, 2019
@spalger spalger deleted the resubmit/32749 branch March 13, 2019 20:27
@lukeelmers
Copy link
Member

Thanks @spalger - I've pulled down a copy of your branch, and opened #33074 which skips the test for now. We will work separately on debugging the flakyness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukeelmers lukeelmers

@ppisljar ppisljar

Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @lukeelmers @ppisljar