Convert saved objects UI to use new import / export API #33513

mikecote · 2019-03-19T15:33:42Z

This PR changes the saved objects management UI to use the new server side APIs for import / export. This also keeps backwards compatibility for old exports (.json files) but displays a warning message that the feature is deprecated.

Other changes in this PR:

By default export will include referenced objects with the option to turn off (see new UI Convert saved objects UI to use new import / export API #33513 (comment))
Server will log a warning when importing legacy .json files
Toast notifications now display once an export file is downloading, modal auto closes (export saved objects dialog needs to have ui indication that export is done #25020)

Fixes #27306
Fixes #22550
Fixes #23557
Fixes #29747
Fixes #25020

elasticmachine · 2019-03-19T15:33:45Z

Pinging @elastic/kibana-platform

mikecote · 2019-03-30T17:59:50Z

Jenkins, test this

mikecote · 2019-04-03T15:36:34Z

UI modifications:

mikecote · 2019-04-03T15:46:23Z

@gchaps I'm trying to find a better alternative than Include all nested references in the screenshots above. Basically it it needs to let the users know that it will export everything the saved object depends on.

For example exporting a dashboard with the option enabled will include visualizations, saved search, index patterns etc that the dashboard would need. It is a recursive option to gather all referenced objects.

Thoughts?

mikecote · 2019-04-03T15:48:55Z

@epixa should the option to include nested references be turned on by default? (as I have in the screenshot above)

epixa · 2019-04-03T16:23:58Z

@mikecote works for me!

joshdover

First pass, still have a few things to review and test.

...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js

src/legacy/ui/public/kfetch/kfetch.ts

…status variable instead

…import-export-ui

...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js

...kibana/public/management/sections/objects/components/objects_table/components/table/table.js

...ugins/kibana/public/management/sections/objects/lib/__jest__/process_import_response.test.js

src/legacy/core_plugins/kibana/public/management/sections/objects/lib/resolve_import_errors.js

elasticmachine · 2019-04-09T01:48:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

joshdover

Tested the various edge cases and it all LGTM. Thanks for refactoring some of the logic for testability.

* Initial work converting UI to use new server side APIs * Remove missed file * Fix jest tests * Code cleanup pt1 * Fix file casing * Fix jest tests * Modify UI to support including nested references * Fix button layout * Connect includeReferencesDeep, remove references_missing_references logic * Fix broken tests * Cleanup * Display success notifications and auto close modals on export * More code cleanup * Log to server when user imports using legacy .json file * Final cleanup * Update test snapshots to match updated text * Apply PR feedback pt1 * Remove isLoading and wasImportSuccessful state variables, use single status variable instead * Move business logic out of flyout component * Apply PR feedback * Update wordings

) * Initial work converting UI to use new server side APIs * Remove missed file * Fix jest tests * Code cleanup pt1 * Fix file casing * Fix jest tests * Modify UI to support including nested references * Fix button layout * Connect includeReferencesDeep, remove references_missing_references logic * Fix broken tests * Cleanup * Display success notifications and auto close modals on export * More code cleanup * Log to server when user imports using legacy .json file * Final cleanup * Update test snapshots to match updated text * Apply PR feedback pt1 * Remove isLoading and wasImportSuccessful state variables, use single status variable instead * Move business logic out of flyout component * Apply PR feedback * Update wordings

* Initial work converting UI to use new server side APIs * Remove missed file * Fix jest tests * Code cleanup pt1 * Fix file casing * Fix jest tests * Modify UI to support including nested references * Fix button layout * Connect includeReferencesDeep, remove references_missing_references logic * Fix broken tests * Cleanup * Display success notifications and auto close modals on export * More code cleanup * Log to server when user imports using legacy .json file * Final cleanup * Update test snapshots to match updated text * Apply PR feedback pt1 * Remove isLoading and wasImportSuccessful state variables, use single status variable instead * Move business logic out of flyout component * Apply PR feedback * Update wordings

mikecote added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects v8.0.0 v7.2.0 labels Mar 19, 2019

mikecote self-assigned this Mar 19, 2019

mikecote added the release_note:enhancement label Mar 26, 2019

mikecote force-pushed the saved-object/import-export-ui branch from dcf5fa5 to ded07a4 Compare March 29, 2019 12:56

mikecote mentioned this pull request Mar 29, 2019

Modify saved object import APIs to handle special use cases from the previous import process #34161

Merged

mikecote force-pushed the saved-object/import-export-ui branch from ded07a4 to f57ae8f Compare March 30, 2019 17:57

This comment has been minimized.

Sign in to view

mikecote force-pushed the saved-object/import-export-ui branch from 95088f9 to 3ed632d Compare April 1, 2019 20:06

This comment has been minimized.

Sign in to view

mikecote added 7 commits April 4, 2019 09:14

Initial work converting UI to use new server side APIs

8c87315

Remove missed file

1f3e7d6

Fix jest tests

5c86393

Code cleanup pt1

73ffff9

Fix file casing

8775a94

Fix jest tests

084890c

Modify UI to support including nested references

2897792

mikecote requested a review from joshdover April 5, 2019 13:17

mikecote added the review label Apr 5, 2019

This comment has been minimized.

Sign in to view

Update test snapshots to match updated text

e604ad5

This comment has been minimized.

Sign in to view

joshdover reviewed Apr 5, 2019

View reviewed changes

Apply PR feedback pt1

2eef662

This comment has been minimized.

Sign in to view

Remove isLoading and wasImportSuccessful state variables, use single …

82759ec

…status variable instead

This comment has been minimized.

Sign in to view

mikecote mentioned this pull request Apr 8, 2019

[Saved Object] Export dashboard and dependencies #34710

Closed

mikecote added 2 commits April 8, 2019 14:46

Move business logic out of flyout component

b38e0f6

Merge branch 'master' of github.com:elastic/kibana into saved-object/…

11fd67f

…import-export-ui

This comment has been minimized.

Sign in to view

joshdover reviewed Apr 8, 2019

View reviewed changes

Apply PR feedback

8cb3d97

This comment has been minimized.

Sign in to view

Update wordings

9389441

joshdover approved these changes Apr 9, 2019

View reviewed changes

mikecote merged commit 962722a into elastic:master Apr 9, 2019

mikecote mentioned this pull request Apr 9, 2019

[7.x] Convert saved objects UI to use new import / export API (#33513) #34802

Merged

This was referenced Apr 10, 2019

Expose object import/export as an API #4759

Closed

Should export all dialog be dismissed after action is complete #21456

Closed

Saved Objects import is successful although the associated index pattern is deleted. #22559

Closed

cjcenizal mentioned this pull request Jun 27, 2019

Allow users to download human-readable JSON when exporting Saved Objects #39857

Closed

rudolf mentioned this pull request Feb 8, 2022

Remove Dashboard Import/Export API #41439

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert saved objects UI to use new import / export API #33513

Convert saved objects UI to use new import / export API #33513

mikecote commented Mar 19, 2019 •

edited

Loading

elasticmachine commented Mar 19, 2019

mikecote commented Mar 30, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mikecote commented Apr 3, 2019

mikecote commented Apr 3, 2019

mikecote commented Apr 3, 2019

This comment has been minimized.

epixa commented Apr 3, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshdover left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

elasticmachine commented Apr 9, 2019

joshdover left a comment

Convert saved objects UI to use new import / export API #33513

Convert saved objects UI to use new import / export API #33513

Conversation

mikecote commented Mar 19, 2019 • edited Loading

elasticmachine commented Mar 19, 2019

mikecote commented Mar 30, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mikecote commented Apr 3, 2019

mikecote commented Apr 3, 2019

mikecote commented Apr 3, 2019

This comment has been minimized.

epixa commented Apr 3, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshdover left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

elasticmachine commented Apr 9, 2019

💚 Build Succeeded

joshdover left a comment

Choose a reason for hiding this comment

mikecote commented Mar 19, 2019 •

edited

Loading