chore: remove the old element ast clearing code #33905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should no longer be needed, this was changed over a year ago
w33ble
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Mar 27, 2019
should no longer be needed, this was changed over a year ago
w33ble
added a commit
that referenced
this pull request
Mar 27, 2019
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
should no longer be needed, this was changed over a year ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is no longer be needed, this was changed over a year ago.
Very early on, I was storing the ast value of an expression on the element object, along with the expression. But the ast value can, and should, be calculated, the only piece we need to store is the expression, otherwise it gets out of sync.
The code here existed so that the value would be purged from the user's state. But the fix went in over a year ago, on Dec 12, 2017, so it's unlikely someone will upgrade from one of the super old technical preview versions to something newer (the future 7.1.0 release in this case).