implementing github checks #34673
Merged
implementing github checks #34673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
mattkime
commented
Apr 18, 2019
src/dev/ci_setup/functions.sh
Outdated
|
|
||
| ### | ||
| ### Implements github-checks-reporter kill switch when scripts are called from the command line | ||
| ### $* - all the arguments |
There was a problem hiding this comment.
need to update this comment
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
spalger
approved these changes
Apr 19, 2019
cjcenizal
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing the github checks api. Supply appropriate env vars and prefix
yarn run github-checks-reporter ${check title}to any CI tasks. Ensure that passing and failing checks work as appropriate.Would be good to look over https://github.com/elastic/github-checks-reporter as well which is a new repo
Take a look at the checks tab to see the results.
Created #34811 which takes the code in this PR and simply fails eslint and a functional test so reviewers can see the results.
Killswitch demo - #35335 - runs all tests without interacting with github-checks-reporter
Killswitch demo w/fail - #35341