[Code] more history test cases #35216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mw-ding
approved these changes
Apr 17, 2019
| await retry.try(async () => { | ||
| expect(await testSubjects.exists('codeFileTreeNode-Directory-src')).to.be(true); | ||
| }); | ||
| await testGoToDefinition(); |
There was a problem hiding this comment.
thanks for the refactoring.
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
|
@WangQianliang any updates on this? please change the base branch to |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Apr 29, 2019
zfy0701
added a commit
that referenced
this pull request
Apr 30, 2019
#35819) * test(code/frontend): more history functional test cases (#35216) * fix(code/frontend): should not collapse folder after click a breadcrumb (#35458) * [Code] fix typeahead highlight file (#35585) * fix(code/frontend): should not collapse folder after click a breadcrumb * fix(code/frontend): should highlight file when jump from typeahead * separate to a independent test case * fix(code/frontend): show loading in directory view (#35720) * fix(code/frontend): fix highlight symbol (#35531) * feature(code/frontend): retry loading symbols if language server is initializing (#35715)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in source view page, switch tab can go back and forward
in search page, apply search filter can go back and forward
go to definition can go back and go to definition again, cover this issue