-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mapbox-gl-draw/dist for IE11 support #36505
Conversation
This package publishes it's transpiled code in a dist directory without updating the package.json's main to point to this file. Since we do not transpile node modules we are updating the require statement to explicitly point to this file. Signed-off-by: Tyler Smalley <[email protected]>
Pinging @elastic/kibana-gis |
Pinging @elastic/kibana-operations |
@spalger curious if there is another suggestion for the handling of this package. |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test this on IE11 now (need to setup that environment first), but verified everything continues to work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this does work in IE11. We'll likely want to merge this before FF tomorrow.
This package publishes it's transpiled code in a dist directory without updating the package.json's main to point to this file. Since we do not transpile node modules we are updating the require statement to explicitly point to this file. Signed-off-by: Tyler Smalley <[email protected]>
This package publishes it's transpiled code in a dist directory without updating the package.json's main to point to this file. Since we do not transpile node modules we are updating the require statement to explicitly point to this file. Signed-off-by: Tyler Smalley <[email protected]>
This package publishes it's transpiled code in a dist directory without updating
the package.json's main to point to this file. Since we do not transpile node
modules, we are updating the require statement to explicitly point to this
file.
Related: #33686