Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana Status Page #3821

Merged
merged 22 commits into from
Jul 10, 2015
Merged

Kibana Status Page #3821

merged 22 commits into from
Jul 10, 2015

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented May 12, 2015

Closes #3270.

Requires Hapi Server rewrite be merged first.

Adds a status page to Kibana, that show metrics and other information about your Kibana Instance.
kibana-status

The status page is viewable by visiting /status

…only show relevant errors, moved over to proper folder, fixed issues caught by jshint
<h2>Server Metrics</h2>
<p>Interval of 5 seconds, with a max history of 5 minutes.</p>
<div id="chart_cont" class="row">
<div ng-repeat="(key, chart) in ui.charts" class="status_chart_wrapper col-md-4">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a directive...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, then you can just put the ng-repeat on that directive

@panda01 panda01 removed the review label Jun 19, 2015
@panda01 panda01 force-pushed the feature/3270/statusPage branch 2 times, most recently from 227a457 to 546521b Compare June 29, 2015 14:11
@w33ble w33ble assigned w33ble and unassigned simianhacker Jul 8, 2015
<section class="section">
<h4>What is this page?</h4>
<p>This page is your sanity check, and your savior. You can check for potential problems</p>
<p>Here is the status of your kibana instance and the plugins you have installed along with some, statistics to asses potential problems.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma here - along with some statistics

@w33ble
Copy link
Contributor

w33ble commented Jul 9, 2015

The status table doesn't work correctly on mobile
screenshot 2015-07-08 17 57 26

Could use a little love in tablet mode too (note the elasticsearch plugin name)
screenshot 2015-07-08 17 58 17

@spalger
Copy link
Contributor

spalger commented Jul 9, 2015

@panda01 @w33ble and everyone else, I'm going to begin merging this into #4335 so please don't rebase or rewrite any commits. 🔪

function getAppStatus() {
// go ahead and get the info you want
$http
.get('/status/health')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and everything under it should have the same indentation as the line above

@spalger spalger mentioned this pull request Jul 10, 2015
@spalger spalger merged commit 8d33e9f into elastic:master Jul 10, 2015
spalger added a commit that referenced this pull request Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server status page
4 participants