Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats collector changed to 1 #39001

Merged
merged 2 commits into from
Jun 14, 2019

Conversation

rashmivkulkarni
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@rashmivkulkarni
Copy link
Contributor Author

retest

1 similar comment
@rashmivkulkarni
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@rashmivkulkarni
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work for now, but it may break in the future. We're just getting lucky with this race condition. The collector really should be waiting on migrations to complete before running.

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying this for now to unblock QA as it only affects the test runner right now

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review June 14, 2019 22:45
@rashmivkulkarni rashmivkulkarni merged commit 5d90300 into elastic:master Jun 14, 2019
@chrisronline
Copy link
Contributor

This might be okay for a long term solution for what we introduced in #36153. We needed someway to remove the arbitrary wait period for testing environments as it lead to inconsistent results. If we start seeing test failures related to tests interacting with the /api/stats api, or related to telemetry in general, we might need to re-evaluate this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants