-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats collector changed to 1 #39001
Stats collector changed to 1 #39001
Conversation
💔 Build Failed |
retest |
1 similar comment
retest |
💚 Build Succeeded |
💚 Build Succeeded |
retest |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work for now, but it may break in the future. We're just getting lucky with this race condition. The collector really should be waiting on migrations to complete before running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying this for now to unblock QA as it only affects the test runner right now
This might be okay for a long term solution for what we introduced in #36153. We needed someway to remove the arbitrary wait period for testing environments as it lead to inconsistent results. If we start seeing test failures related to tests interacting with the |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers