Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Controls - adds matrix for feature availability #39078

Merged
merged 5 commits into from
Nov 21, 2019
Merged

Feature Controls - adds matrix for feature availability #39078

merged 5 commits into from
Nov 21, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Jun 17, 2019

Summary

Adds a matrix explaining when features are available to end users based on the space and role configuration. It's a port of the table outlined in this issue.

/cc @jinmu03

@legrego legrego added Team:Docs Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes labels Jun 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb kobelb self-requested a review June 17, 2019 16:15
@legrego legrego requested a review from gchaps June 17, 2019 18:04
gchaps
gchaps reviewed Jun 18, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legrego The content is good. However, I feel it is hidden under the examples on this page. Can you find a better place for this content?

@legrego
Copy link
Member Author

legrego commented Jun 18, 2019

We have this "important" callout here, which is effectively a consolidated version of this PR. What if we remove this important callout, and place this new section immediately after that "Adding kibana privileges" section (before the "Assigning different privileges to different spaces" section)?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit a853609 into elastic:master Nov 21, 2019
@legrego legrego deleted the fc/cheat-sheet-doc branch November 21, 2019 20:09
This was referenced Nov 21, 2019
Merged
Merged
legrego added a commit to legrego/kibana that referenced this pull request Nov 21, 2019
@legrego
Feature Controls - adds matrix for feature availability (elastic#39078)
76e0897 
* document feature availability

* move feature table
legrego added a commit to legrego/kibana that referenced this pull request Nov 21, 2019
@legrego
Feature Controls - adds matrix for feature availability (elastic#39078)
67b2e7f 
* document feature availability

* move feature table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@kobelb kobelb kobelb approved these changes

Assignees
No one assigned
Labels
Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legrego @elasticmachine @kobelb @gchaps