handle mupltiple cookies sent from a browser #39431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
34 tasks
💚 Build Succeeded |
joshdover
approved these changes
Jun 24, 2019
| public async get(): Promise<T | null> { | ||
| try { | ||
| return await this.server.auth.test('security-cookie', this.request as Request); | ||
| const session = await this.server.auth.test('security-cookie', this.request); |
There was a problem hiding this comment.
Should this string be pulled from a shared constant?
There was a problem hiding this comment.
Don't think so.
- Strategy name is declared in the same file:
This knowledge shouldn't leak outside. - I believe that
shared constantwon't exist in the New platform. They are always a part of a domain and should be passed accordingly, with declaring direct dependencies.
| @@ -221,6 +223,7 @@ export class HttpServer { | |||
| this.authRegistered = true; | |||
|
|
|||
| const sessionStorageFactory = await createCookieSessionStorageFactory<T>( | |||
| this.logger.get('http', 'server', this.name, 'cookie-session-storage'), | |||
There was a problem hiding this comment.
It'd be kinda nice if the Logger interface had a get function for creating sub-loggers:
const httpLog = loggerFactory.get('http', 'server')
const cookieSessionStorageLog = httpLog.get('cookie-session-storage')But that's a change for another day...
There was a problem hiding this comment.
I also was surprised that Logger doesn't provide this functionality. Created issue #39695
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Jun 27, 2019
mshustov
added a commit
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support a case for
ScopedCookieSessionStoragewhen browser sends multiple cookies with the same name.based on the current implementation https://github.com/restrry/kibana/blob/e4f538df0a048b469eb1189c34484cf8699944a6/x-pack/legacy/plugins/security/server/lib/authentication/session.ts#L59
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11-
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers