Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to 12.1.0 #39601

Merged
merged 12 commits into from
Jun 26, 2019
Merged

Upgrade EUI to 12.1.0 #39601

merged 12 commits into from
Jun 26, 2019

Conversation

thompsongl
Copy link
Contributor

Summary

[email protected] ⏩ [email protected]

Breaking change was removal of core-js, which largely only impacted Jest

12.1.0

  • Changed EuiNavDrawerFlyout title from h5 to div (#2040)
  • Converted EuiGlobalToastList into ARIA live region by adding role="region" attribute to add NVDA/JAWS support (#2055)
  • Added magnifyWithMinus and magnifyWithPlus glyphs to EuiIcon (2056)
  • Added a fully black (no matter the theme) color SASS variable $euiColorInk (2060)
  • Added autoFocus prop to EuiTabbedContent (2062)
  • Changed popout glyph in EuiIcon to look more like external link (2064)
  • Tweaked SuperDatePicker to make the start/end date selection more obvious (#2049)
  • Added toSentenceCase string service (#2049)
  • Pass EuiSuperSelect's popoverClassName to the popover's panel (#2068)
  • Added editorItemAlignLeft, editorItemAlignCenter, editorItemRight, editorItemAlignTop, editorItemAlignMiddle, editorItemAlignBottom, editorDistributeHorizontal, editorDistributeVertical, editorPositionTopLeft, editorPositionTopRight, editorPositionBottomRight, and editorPositionBottomLeft glyphs to EuiIcon (2070)
  • Added missing TS definitions for EuiRange (#2072)

Bug fixes

  • Fixed proptype for EuiCopy's children (#2048)
  • Fixed EuiInMemoryTable to allow sorting on computed columns (#2044)
  • Fixed TypeScript Toast member export (#2052)
  • Fixed style of readOnly input groups via EuiFormControlLayout and prepend/append (#2057)
  • Removed TS types from ES exports when the exported name differs from the imported one (#2069)
  • Fixed TypeScript definitions and type exports for EuiBadge and EuiCopy (#2052)

12.0.0

  • Attached noreferrer also to links without target="_blank" (#2008)
  • Converted observer utility components to TypeScript (#2009)
  • Converted tool tip components to TypeScript (#2013)
  • Converted EuiCopy to TypeScript (#2016)
  • Converted badge and token components to TypeScript (#2026)
  • Added magnet glyph to EuiIcon (2010)
  • Changed logoAWS SVG in EuiIcon to work better in dark mode (#2036)
  • Converted toast components to TypeScript (#2032)

Bug fixes

  • Fixed EuiFlyout scrolling in Safari (#2033)
  • Fixed EuiCallOut header icon alignment (#2006)
  • Fixed EuiInMemoryTable sort value persistence through lifecycle updates (#2035)
  • Fixed EuiColorPicker positioning and keyboard navigation in certain portal contexts (#2038)

Breaking changes

  • Removed explicit dependency on core-js, but a global polyfill like core-js@3 is still required (#1982)

@thompsongl thompsongl added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels Jun 25, 2019
@thompsongl thompsongl requested review from a team as code owners June 25, 2019 17:37
chandlerprall
chandlerprall suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small nits

src/dev/jest/setup/babel_polyfill.js Show resolved Hide resolved
x-pack/legacy/plugins/beats_management/public/components/tag/tag_badge.tsx Show resolved Hide resolved
x-pack/legacy/plugins/siem/public/components/draggables/index.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/properties/helpers.tsx Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

eliperelman
eliperelman approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spalger
spalger approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little ask, but LGTM from operations

package.json Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM 🎉

@legrego legrego mentioned this pull request Jun 26, 2019
Closed
4 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

chandlerprall
chandlerprall approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@thompsongl thompsongl merged commit c598755 into elastic:master Jun 26, 2019
@thompsongl thompsongl mentioned this pull request Jun 26, 2019
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jun 26, 2019
@thompsongl
Upgrade EUI to 12.1.0 (elastic#39601)
13070b1 
* [email protected]

* jest regenerator-runtime babel-polyfill

* TS Toast -> EuiGlobalToastListToast

* EuiBadge

* EuiCopy

* snapshot updates

* simplify toast interface usage

* misc review cleanup

* remove eui core-js resolution
thompsongl added a commit that referenced this pull request Jun 26, 2019
@thompsongl
[7.x] Upgrade EUI to 12.1.0 (#39601) (#39699)
4070c58 
* Upgrade EUI to 12.1.0 (#39601)

* [email protected]

* jest regenerator-runtime babel-polyfill

* TS Toast -> EuiGlobalToastListToast

* EuiBadge

* EuiCopy

* snapshot updates

* simplify toast interface usage

* misc review cleanup

* remove eui core-js resolution

* toast interface import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@eliperelman eliperelman eliperelman approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thompsongl @elasticmachine @walterra @eliperelman @chandlerprall @spalger