-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use refreshIntervalDefaults from config #3977
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Can you merge master on this how that #3915 has been merged? |
ae4136b
to
1966c79
Compare
Rebased on master |
Merging #3976 broke this one :-) One more master merge and this should be good! |
1966c79
to
28f513b
Compare
Rebased once again :-) |
@BigFunger @rashidkpc is it good now ? |
@Filirom1, I was reviewing this change, and was unable to get it to work the way that I expected it to work. It seems like the config.get call is happening before the stored configuration is being loaded. So, if you make a change in the settings/advanced section, those changes do not get used. How are you avoiding that issue? |
This last commit will do the job: worldline@6bf7509 This will be the last PR extracted from #3908 But if you prefer, I can include this commit here. |
@Filirom1, I took a look at worldline@6bf7509 I think it's close, but there's a few small changes that I would like to suggest.
these changes are intended to provent
patch gist:
Please review the changes, and let me know if you want me to apply them. |
Wao, thank you. |
Replaced by #4473 |
This is an extraction of the refreshIntervalDefaults part of #3908
Right now, this PR failed because of a circular dependency.
Once #3915 merged, this PR will pass.
The field
display
is needed because it contains the strings that will be displayed in the top bar.I removed the field
section
, it's useless.